Could not connect to server

[oleosjo]

🐞 bug report

Description

Tried running scully on an angular 9 app, got an error.

🔬 Minimal Reproduction

Run scully

💻Your Environment

Angular CLI: 9.0.0-rc.6
Node: 12.8.1
OS: darwin x64

🔥 Exception or Error

started servers in background
Could not connect to server

[jorgeucano]

Can you give me more info?
Can you create a repo for try? i need more description about your environment!

[isaacplmann]

I get the same error in the scully branch of this repo:
https://github.com/isaacplmann/nx-monorepo-sample/tree/scully

I'm trying to get scully working in an nx monorepo, so maybe there's some hard-coded path that is expecting a default Angular CLI set up?

yarn run v1.19.1
$ scully
Cleaned up /Users/isaac/Documents/code/nx-monorepo-sample/dist/static/ folder.
 ☺   new Angular build imported
started servers in background
Could not connect to server
✨  Done in 17.08s.

[isaacplmann]

Could be related to lazy-loading routes with tsconfig path aliases.

yarn scully:serve gives this error:

$ scully serve
starting static server...
Could not start Scully serve Error: Scully could not traverse routes

And AppModule loads its routes like this:

  {
    path: 'home',
    loadChildren: () => import('@ng-cli-app/home/ui').then(m => m.HomeUiModule),
    canActivate: [AuthGuard]
  },

[Splaktar]

Possibly related to #31 as I saw this first before I saw the extra info from the errors in that issue.

Update: They appear to be separate issues as that issue isn't seeing any problems with reading the routes.

[isaacplmann]

Oops, I missed the first line of getting started that says you need Angular 9.x. I'll upgrade and report back

[isaacplmann]

I've updated that repo to angular 9 and am still getting the same error. I think guess is having trouble with the lazy loaded routes.

I added a console.log to node_modules/@scullyio/scully/node_modules/guess-parser/dist/guess-parser/index.js

var collectRoutingModules = function (root, registry, result, parentPath, currentPath) {
    if (parentPath === void 0) { parentPath = root; }
    if (currentPath === void 0) { currentPath = ''; }
    console.log('root', root);
    var declaration = registry[root];
    var process = function (r) {
        if (r.module) {

And modified node_modules/@scullyio/scully/bin/routerPlugins/traverseAppRoutesPlugin.js

exports.traverseAppRoutes = async (appRootFolder = config_1.scullyConfig.projectRoot) => {
    try {
        const routes = guess_parser_1.parseAngularRoutes(appRootFolder).map(r => r.path);
        return routes;
    }
    catch (e) {
        console.log('e',e)
        throw new Error('Scully could not traverse routes');
    }
};

And this is what shows up when I run yarn scully:serve:

root /Users/isaac/Documents/code/nx-monorepo-sample/apps/ng-cli-app/src/app/app.module.ts
root /Users/isaac/Documents/code/nx-monorepo-sample/apps/ng-cli-app/src/app/@ng-cli-app/home/ui.ts
e TypeError: Cannot read property 'eagerRoutes' of undefined
    at collectRoutingModules (/Users/isaac/Documents/code/nx-monorepo-sample/node_modules/@scullyio/scully/node_modules/guess-parser/dist/guess-parser/index.js:464:17)
    at processLazyRoute (/Users/isaac/Documents/code/nx-monorepo-sample/node_modules/@scullyio/scully/node_modules/guess-parser/dist/guess-parser/index.js:462:9)
    at Array.forEach (<anonymous>)

[isaacplmann]

This line /Users/isaac/Documents/code/nx-monorepo-sample/apps/ng-cli-app/src/app/@ng-cli-app/home/ui.ts is obviously not a valid file path.