fix(could not connect to server): explain the reasons#216
Merged
SanderElias merged 1 commit intomasterfrom Jan 22, 2020
Merged
Conversation
…t connect This pr adds a better handling when we fail to traverse routes in the angular app, and explains the most common reasons. closes #40
jorgeucano
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds better handling when we fail to traverse routes in the angular app, and explains the
most common reasons.
closes #40
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Scully throws a non-descript error (
could not connect to server) when it can not properly parse the routes n the applicationIssue Number: #40
What is the new behavior?
It describes what happened and gives you a path to a solution to the issue.
Also, it warns when there is no
Does this PR introduce a breaking change?