fix(scully): fix Could not connect to server#178
Merged
jorgeucano merged 3 commits intomasterfrom Jan 15, 2020
Merged
Conversation
…ymore added better support for handling multiple servers, added better error messages.
Contributor
|
I added a few things to this pr. @jorgeucano you might want to review this one too. |
SanderElias
approved these changes
Jan 11, 2020
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
LGTM
But checkout the changes I did
aaronfrost
reviewed
Jan 14, 2020
aaronfrost
reviewed
Jan 14, 2020
aaronfrost
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fix problem with Could not connect to server
What is the current behavior?
Issue Number: #40
What is the new behavior?
Does this PR introduce a breaking change?
Other information