Skip to content

fix(scully): watchMode: fix problem with ghost service in mac#349

Merged
SanderElias merged 1 commit intomasterfrom
fix/339
Mar 3, 2020
Merged

fix(scully): watchMode: fix problem with ghost service in mac#349
SanderElias merged 1 commit intomasterfrom
fix/339

Conversation

@jorgeucano
Copy link
Copy Markdown
Contributor

@jorgeucano jorgeucano commented Mar 3, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

ScullyServer keeps running even though I quit it with Cmd + C or "q"

Issue Number: #339

What is the new behavior?

Fix this error waiting for kill servers

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano
Copy link
Copy Markdown
Contributor Author

@aaronfrost I test in my mac and the fix worked... But, can you test in your computer, i really love to test and check with a mac first user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants