Skip to content

fix(scully): watchMode: fix problem with ghost service in mac #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanderElias merged 1 commit into from
Mar 3, 2020
Merged

fix(scully): watchMode: fix problem with ghost service in mac #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scully/watchMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {loadConfig} from './utils/config';
import {checkChangeAngular} from './utils/fsAngular';
import {checkStaticFolder} from './utils/fsFolder';
import {httpGetJson} from './utils/httpGetJson';
import {log, logError, yellow, green} from './utils/log';
import {log, logError, yellow, green, logWarn} from './utils/log';
import {closeExpress, staticServer} from './utils/staticServer';

export async function bootServe(scullyConfig: ScullyConfig) {
Expand Down Expand Up @@ -45,14 +45,21 @@ export function checkForManualRestart() {
output: process.stdout,
});

readline.question(``, command => {
readline.question(``, async command => {
if (command.toLowerCase() === 'r') {
startScully().then(() => {
readline.close();
checkForManualRestart();
});
} else if (command.toLowerCase() === 'q') {
await httpGetJson(`http://${scullyConfig.hostName}:${scullyConfig.appPort}/killMe`, {
suppressErrors: true,
}).catch(e => e);
await httpGetJson(`https://${scullyConfig.hostName}:${scullyConfig.appPort}/killMe`, {
suppressErrors: true,
}).catch(e => e);
process.exit(0);
return;
} else {
log(`${yellow('------------------------------------------------------------')}`);
log(`Press ${green('r')} for re-run Scully, or ${green('q')} for close the servers.`);
Expand Down