Fix/watch mode#59
Merged
jorgeucano merged 8 commits intomasterfrom Dec 20, 2019
Merged
Conversation
get support for error message when scully kill the app
SanderElias
reviewed
Dec 19, 2019
|
|
||
| if (!existDistAngular(scullyConfig.homeFolder)) { | ||
| process.exit(0); | ||
| try { |
Contributor
There was a problem hiding this comment.
why is there a try here? proccess.exit doesn't usually fail?
Contributor
Author
There was a problem hiding this comment.
I will eliminate the try / catch ... the output works fine!
It is a test that I left unintentionally.
SanderElias
reviewed
Dec 19, 2019
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
ping me when you are back online
Contributor
|
Where are we at on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(scully): rewrite watch mode
change all from the watch mode for support the new config, and some hotfix.
Fix problem with gosth node process