fix(docs): book component#715
Merged
SanderElias merged 5 commits intomainfrom Jul 14, 2020
Merged
Conversation
aaronfrost
reviewed
Jul 8, 2020
GuzmanPI
force-pushed
the
fix/landing-broken-links
branch
from
a84287f to
d21d94a
Compare
jorgeucano
approved these changes
Jul 9, 2020
Contributor
|
@GuzmanPI can you gix the MC |
GuzmanPI
force-pushed
the
fix/landing-broken-links
branch
from
d21d94a to
64231e5
Compare
jorgeucano
reviewed
Jul 13, 2020
GuzmanPI
force-pushed
the
fix/landing-broken-links
branch
2 times, most recently
from
6c8b3cf to
d4b4b1f
Compare
Fix test snapshots
GuzmanPI
force-pushed
the
fix/landing-broken-links
branch
from
d4b4b1f to
52e70d2
Compare
SanderElias
reviewed
Jul 14, 2020
| @@ -1,8 +1,8 @@ | |||
| <div> | |||
| <a [href]="href"> | |||
Contributor
There was a problem hiding this comment.
Why don't you use routerlink?
SanderElias
reviewed
Jul 14, 2020
| export class BookComponent implements OnInit { | ||
| @Input() header: string; | ||
| @Input() text: string; | ||
| @Input() href: string; |
Contributor
There was a problem hiding this comment.
Reusing an existing and meaningfull attribute might become an issue later on.
SanderElias
reviewed
Jul 14, 2020
|
|
||
| <div class="container-tools"> | ||
| <div class="guide-1" [routerLink]="'/docs/getting-started'"> | ||
| <div class="guide-1"> |
Contributor
There was a problem hiding this comment.
perhaps exchange the div for an instead of bolting on things?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an href property to the component, so it redirects.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Improves the book component in the docs app. It also changes the landing components so they redirect to a proper url.
What is the current behavior?
The book components in the landing page do not redirect.
Issue Number: #710
What is the new behavior?
The book components in the landing page redirect.
Does this PR introduce a breaking change?
Other information