-
Notifications
You must be signed in to change notification settings - Fork 252
fix(docs): book component #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
52e70d2
fix(docs): book component
GuzmanPI e28c752
Merge branch 'main' of github.com:scullyio/scully into fix/landing-br…
jorgeucano 852f534
WIP:
jorgeucano 21009b0
change the href to routerLink
jorgeucano d489581
Merge branch 'fix/landing-broken-links' of github.com:scullyio/scully…
jorgeucano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| <div> | ||
| <a [routerLink]="href"> | ||
| <img src="assets/book.png" alt="Book icon" /> | ||
|
|
||
| <div class="card-content"> | ||
| <h3>{{ header }}</h3> | ||
| <p>{{ text }}</p> | ||
| </div> | ||
| </div> | ||
| </a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,6 +145,7 @@ main { | |
| .guide-2 { | ||
| grid-column-start: inherit; | ||
| grid-column-end: inherit; | ||
| cursor: pointer; | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ <h3>FEATURES</h3> | |
| [header]="'Runtime Tooling'" | ||
| text=" | ||
| Scully gives developers the necessary tools | ||
| to Jamstackify any Angular project, | ||
| to Jamstackify any Angular project, | ||
| including fine-grained control where needed. | ||
| " | ||
| [iconUrl]="'assets/machine-learning.png'" | ||
|
|
@@ -109,15 +109,17 @@ <h3>TOOLS & RESOURCES</h3> | |
| </div> | ||
|
|
||
| <div class="container-tools"> | ||
| <div class="guide-1" [routerLink]="'/docs/getting-started'"> | ||
| <div class="guide-1"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perhaps exchange the div for an instead of bolting on things? |
||
| <app-book | ||
| [href]="'docs/getting-started/'" | ||
| [header]="'Guides'" | ||
| [text]="'Easy step by step guides to help get you started.'" | ||
| > | ||
| </app-book> | ||
| </div> | ||
| <div class="guide-2" [routerLink]="'/docs/blog'"> | ||
| <div class="guide-2"> | ||
| <app-book | ||
|
GuzmanPI marked this conversation as resolved.
|
||
| [href]="'docs/blog/'" | ||
| [header]="'Create a Blog'" | ||
| [text]=" | ||
| 'Easy step by step to create your own blog in less than 5 minutes.' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 28 additions & 28 deletions
56
tests/jest/src/__tests__/__snapshots__/docsThere.spec.ts.snap
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing an existing and meaningfull attribute might become an issue later on.