Skip to content

Fix read_generic_wrapper test #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2025
Merged

Fix read_generic_wrapper test #301

merged 11 commits into from
Apr 15, 2025

Conversation

melonora
Copy link
Collaborator

The test failed on the last assert. This because the code generates a ValueError. With click this does not end up in the output but in the atttribute exc_info. Lastly, the error message was also different from the error message in the assert.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.53%. Comparing base (296d9a5) to head (386b634).
Report is 157 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #301       +/-   ##
===========================================
+ Coverage   39.16%   49.53%   +10.37%     
===========================================
  Files          26       26               
  Lines        2663     2709       +46     
===========================================
+ Hits         1043     1342      +299     
+ Misses       1620     1367      -253     

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melonora melonora merged commit 1fba5a6 into scverse:main Apr 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants