#5346 Uninstall older non-velopack viewer#5363
Merged
Merged
Conversation
akleshchev
force-pushed
the
andreyk/velopack_uninstall
branch
from
1e6d6b6 to
345a3d6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to detect and uninstall older NSIS-based viewer installations when a new Velopack-based version is installed. It also enhances the NSIS uninstaller with silent operation capabilities through new command-line flags.
Changes:
- Adds detection of NSIS-based installations and prompts users to uninstall them during fresh Velopack installs
- Introduces
/clearregand/clrusrfilesflags to the NSIS uninstaller for silent operation - Adds registry entries for help and support URLs in the Velopack installer
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/notifications.xml | Adds user notification for prompting NSIS uninstallation |
| indra/newview/llvelopack.h | Declares namespace variable and function for NSIS detection |
| indra/newview/llvelopack.cpp | Implements NSIS uninstaller detection and adds support URLs to registry |
| indra/newview/llstartup.cpp | Integrates NSIS uninstall prompt into startup flow |
| indra/newview/installers/windows/installer_template.nsi | Adds silent uninstall command-line options |
| indra/cmake/CMakeLists.txt | Adds Velopack.cmake to build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/velopack_uninstall
branch
7 times, most recently
from
23b0d7b to
ab69410
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/velopack_uninstall
branch
4 times, most recently
from
6d8d324 to
d176c24
Compare
if of the same channel
akleshchev
force-pushed
the
andreyk/velopack_uninstall
branch
from
d176c24 to
34ef3dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uninstall older non-velopack viewer if of the same channel
Pull in clear registry change to make uninstall truly silent when possible.