-
Notifications
You must be signed in to change notification settings - Fork 68
fix: Composer configuration, typos and type hints #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Composer extension requirements (json, curl) Client: magic method 'unsubcribes' -> 'unsubscribes' Exception throw blocks Typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo fixes LGTM, thanks!
With respect to
Do you mean that there is an error when you try to pass in Thanks! |
Hi Elmer. This is not a functional error, just an incomplete PHPDoc magic method definition just having 3 arguments which are available for usage. If providing 4th argument (like in the example.php), phpStorm will report the use of an unsupported 4th argument. Function __call handles execution of magic methods Easy fix for this: append
|
…t, post, patch, put and delete
Just came to submit a typo, but I found a few small issues while reviewing this library using phpStorm:
Throwable
when using PHP 5.6 (which is minimal PHP version requirement for this library, I reported it in separate issue)ps. In addition of this, I've found missing 4th argument of magic
get()
method in example.php:$response = $client->api_keys()->get(null, $queryParams, $requestHeaders, $retryOnLimit);
Not a big thing. Just mentioning.
Checklist