Skip to content

fix: Composer configuration, typos and type hints #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2020
Merged

fix: Composer configuration, typos and type hints #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5e25f8
Found few small issues while reviewing using phpStorm
kampalex Jun 4, 2020
eb1a4c9
Client: Added PHPDoc definition for 4th argument for magic methods ge…
kampalex Jun 10, 2020
b7635e1
Merge branch 'master' into feat-review
thinkingserious Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
}
],
"require": {
"php": ">=5.6"
"php": ">=5.6",
"ext-curl": "*",
"ext-json": "*"
},
"require-dev": {
"phpunit/phpunit": "~4.4",
Expand Down
16 changes: 9 additions & 7 deletions lib/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
*
* Quickly and easily access any REST or REST-like API.
*
* @method Response get($body = null, $query = null, $headers = null)
* @method Response post($body = null, $query = null, $headers = null)
* @method Response patch($body = null, $query = null, $headers = null)
* @method Response put($body = null, $query = null, $headers = null)
* @method Response delete($body = null, $query = null, $headers = null)
* @method Response get($body = null, $query = null, $headers = null, $retryOnLimit = null)
* @method Response post($body = null, $query = null, $headers = null, $retryOnLimit = null)
* @method Response patch($body = null, $query = null, $headers = null, $retryOnLimit = null)
* @method Response put($body = null, $query = null, $headers = null, $retryOnLimit = null)
* @method Response delete($body = null, $query = null, $headers = null, $retryOnLimit = null)
*
* @method Client version($value)
* @method Client|Response send()
Expand Down Expand Up @@ -123,14 +123,14 @@
* @method Client subusers()
* @method Client reputations()
*
* Supressions
* Suppressions
* @method Client suppression()
* @method Client global()
* @method Client blocks()
* @method Client bounces()
* @method Client invalid_emails()
* @method Client spam_reports()
* @method Client unsubcribes()
* @method Client unsubscribes()
*
* Templates
* @method Client templates()
Expand Down Expand Up @@ -432,6 +432,7 @@ private function parseResponse($channel, $content)
* @param array $headers original headers
*
* @return Response response object
* @throws InvalidRequest
*/
private function retryRequest(array $responseHeaders, $method, $url, $body, $headers)
{
Expand Down Expand Up @@ -562,6 +563,7 @@ public function _($name = null)
* @param array $args parameters passed with the method call
*
* @return Client|Response|Response[]|null object
* @throws InvalidRequest
*/
public function __call($name, $args)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/Exception/InvalidRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*
* Thrown when invalid payload was constructed, which could not reach SendGrid server.
*
* @package SendGrid\Exceptions
* @package SendGrid\Exception
*/
class InvalidRequest extends \Exception
{
Expand Down