fix: implicitly nullable parameter deprecation in PHP 8.4 #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love to see this merged soon. |
|
Created #167 for this. I think we can close this one |
|
Why was this closed? It looks like #167 copies my work without proper attribution. The additional changes there seem unrelated to fixing the PHP 8.4 deprecation, so wouldn't it be better to make them separately after merging this? |
|
My apologies @theodorejb. Let me fix the other issue with tests and then we can push this change |
tiwarishubham635
approved these changes
Apr 7, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enabled testing on PHP 8.2, 8.3, and 8.4.