Skip to content

fix: remove PHP 8.4 deprecation warning #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Apr 4, 2025

Fixes

  1. PHP 8.4 requires nullable parameters to be declared with a ?, so added that change
  2. Updating licence year to 2025

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tiwarishubham635 tiwarishubham635 changed the title chore: update licence year fix: remove PHP 8.4 deprecation warning Apr 4, 2025
* @param array $body request body
* @param array $headers any additional request headers
* @param bool $retryOnLimit should retry if rate limit is reach?
* @param string $method the HTTP verb
Copy link

@manisha1997 manisha1997 Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param string $method the HTTP verb
* @param string $method The HTTP verb.
* @param string $url The final URL to call.
* @param array|null $body The request body.
* @param array|null $headers Any additional request headers.
* @param bool $retryOnLimit Should retry if the rate limit is reached?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add backslashes before the parameter names?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

tiwarishubham635 and others added 2 commits April 7, 2025 11:55
Co-authored-by: Manisha Singh <[email protected]>
Co-authored-by: Manisha Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants