Skip to content

Improve connection handling and reconnection logic #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfstar wants to merge 26 commits into from
Closed

Improve connection handling and reconnection logic #301

sfstar wants to merge 26 commits into from

Conversation

@sfstar
Copy link
Owner

@sfstar sfstar commented Feb 28, 2025

Breaking change

Proposed change

PR to increase debugeability of connection issues as well as improve connection loss handling. Should be merged after #274

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format custom_components/victron)

sfstar added 15 commits January 27, 2025 23:18
@sfstar
add registers up until version 3.50 as discoverable
8973883 
updates all changes from the spec sheet from the version used at the end of 2022 in favor of xlsx released for 3.50 venus os version
@sfstar
also version the spec sheet on which the const.py decoding is based
fc2e3d1
@sfstar
resolved incorrect imports
c64027f
@sfstar
resolve decoding issues
713ed0f
@sfstar
add uint64 support for decoding new uint64 registers introduced by ho…
5cbbdf7 
…meassistant
@sfstar
Merge branch 'main' into feature/add_all_registers_that_were_added_to…
5482d3a 
…_venus_since_integration_inception
@sfstar
resolve ruff check errors for newly introduced registers
aa7ad5d
@sfstar
change if logic in number.py
2a37f9f
@sfstar
adding ah as own unit of measurement since global ha support is on-hold
e32cb22
@sfstar
add uint/int64 support for new registers that require them
96ce743
@sfstar
process ruff finding
70393b3
@sfstar
improve error logging on connection failure
6f17a01
@sfstar
change connection availability var to reflect actual state
46e2e59
@sfstar
make reading registers more robust
e431274
@sfstar
add reconnection logic to write registers as well
8c82c44
@sfstar sfstar force-pushed the bugfix/change_connection_logic_to_become_more_robust branch from 152ff0d to 8c82c44 Compare February 28, 2025 08:21
@sfstar sfstar added bugfix Inconsistencies or issues which will cause a problem for users or implementors. in-progress Issue is currently being resolved by a developer. priority-critical This should be dealt with ASAP. Not fixing this issue would be a serious error. labels Feb 28, 2025
@sfstar sfstar changed the title Bugfix/change connection logic to become more robust Improve connection handling and reconnection logic Feb 28, 2025
@sfstar sfstar force-pushed the bugfix/change_connection_logic_to_become_more_robust branch from 5724558 to 85a7dc3 Compare March 7, 2025 07:41
@github-actions
Copy link

github-actions bot commented Jun 10, 2025

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jun 10, 2025
@github-actions github-actions bot closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors. in-progress Issue is currently being resolved by a developer. priority-critical This should be dealt with ASAP. Not fixing this issue would be a serious error. stale There has not been activity on this issue or PR for quite some time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfstar @sventenraa