Skip to content

Conversation

@sfstar
Copy link
Owner

@sfstar sfstar commented Jan 27, 2025

PR that prepares for the addition of all registers added or changed between the initial version from end of 2022 to the current v 3.5 version of the victron register spec. On hold until future is determined

updates all changes from the spec sheet from the version used at the end of 2022 in favor of xlsx released for 3.50 venus os version
@sfstar sfstar added breaking-change A breaking change for existing users. new-feature New features or options. labels Feb 3, 2025
@sfstar
Copy link
Owner Author

sfstar commented Feb 3, 2025

Some of the registers added in this PR don't return values which needs to be further investigated before merging this PR

@sfstar
Copy link
Owner Author

sfstar commented Feb 3, 2025

PR also introduces custom Ah unit of measurement since the discussion on the ha architecture repo has stalled: home-assistant/architecture#1052
The integration that currently uses Ah from within core uses an string definition of Ah.
Therefore, in preparation for future change and data consistency in the mean time this PR will introduce AMPHOURS as an constant and switch over the specific entities to Ah. Migration path Either through code or by release note instructions needs to be investigated

@github-actions
Copy link

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 30, 2025
@github-actions github-actions bot closed this May 30, 2025
@sfstar sfstar reopened this Jun 1, 2025
@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jun 1, 2025
@tomer-w
Copy link

tomer-w commented Jun 10, 2025

Hi @sfstar, thanks for all of your hard work here. Is there anything blocking this checkin? It has lot of valuable registers added here.

@sfstar sfstar added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jul 5, 2025
@sfstar
Copy link
Owner Author

sfstar commented Aug 26, 2025

@tomer-w,

This PR was almost ready to be merged.
I see the benefits of recommitting to getting this PR to land.
Unfortunately, I'm really scatter brained and I forget to consistently work on this integration as a result.

Have blocked an calender item for this weekend to see if I can land this PR.
For now I've resolved the merge conflicts.

Edit:
I've just tested it (to re-orient me on what was missing for this pr to be merged).
For existing intstallations the upgrade works fine however one of the updated register sets seems to be to large to query via modbus.
Thereby preventing scans and initial setup of the integration.
As far as it seems now it only needs some of the register sets to be split up for this change to be mergeable.

@sfstar sfstar merged commit 9457f0d into main Aug 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change for existing users. bugfix Inconsistencies or issues which will cause a problem for users or implementors. new-feature New features or options.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants