Skip to content

Conversation

@jacauc
Copy link
Contributor

@jacauc jacauc commented Aug 28, 2025

Attempt to make victron integration compatible with pymodbus API 3.10.0 and greater

"Change slave to device_id and slave= to device_id=. (#2600)"

https://pymodbus.readthedocs.io/en/latest/source/api_changes.html

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format custom_components/victron)

Attempt to make victron integration compatible with pymodbus API 3.10.0 and greater

"Change slave to device_id and slave= to device_id=. (#2600)"

https://pymodbus.readthedocs.io/en/latest/source/api_changes.html
@jacauc jacauc changed the title Update hub.py Update hub.py to be compatible with PyModbus >=3.10 and HA 2025.9 Aug 28, 2025
@jacauc jacauc marked this pull request as draft August 28, 2025 11:34
@jacauc jacauc marked this pull request as ready for review August 28, 2025 11:34
@sfstar sfstar added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Aug 31, 2025
@sfstar
Copy link
Owner

sfstar commented Aug 31, 2025

Thank you for opening this pr,
Do you know/have you tested this fix with the non-beta version 2025.8.x?
Will look into merging this tommorow (will have to revert the beta pr for the 0.7.0-beta release in order to allow this to be released as an hotfix before wednesday).

sfstar added a commit that referenced this pull request Aug 31, 2025
…ers_that_were_added_to_venus_since_integration_inception

Revert "Feature/add all registers that were added to venus since integration inception" in order to allow #362 to be merged as an hotfix
Copy link
Owner

@sfstar sfstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Didn't test it with the beta release as of yet but it matches the changelog of pymodbus pr #2600 https://pymodbus.readthedocs.io/en/latest/source/changelog.html#version-3-10-0 and home-assistant/core@7572b2a with the pr of the upcoming 2025.9 beta release

@sfstar sfstar merged commit bc70959 into sfstar:main Aug 31, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants