Skip to content

Make integration compatible with pymodbus 3.11.0 for Hass 2025.9 #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jochen754 wants to merge 1 commit into from
Closed

Make integration compatible with pymodbus 3.11.0 for Hass 2025.9 #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions custom_components/victron/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ def disconnect(self):

def write_register(self, unit, address, value):
"""Write a register."""
slave = int(unit) if unit else 1
return self._client.write_register(address=address, value=value, device_id=slave)
device_id = int(unit) if unit else 1
return self._client.write_register(address=address, value=value, device_id=device_id)

def read_holding_registers(self, unit, address, count):
"""Read holding registers."""
slave = int(unit) if unit else 1
device_id = int(unit) if unit else 1
return self._client.read_holding_registers(
address=address, count=count, device_id=slave
address=address, count=count, device_id=device_id
)

def calculate_register_count(self, registerInfoDict: OrderedDict):
Expand Down