Repository navigation
Conversation
cfaf2cf to
902859b
Compare
a2c37f0 to
046cd52
Compare
902859b to
f60333c
Compare
caf6b36 to
cbd25ea
Compare
1e49efb to
a5abcfc
Compare
cbd25ea to
2994494
Compare
This comment has been minimized.
This comment has been minimized.
2994494 to
5190238
Compare
This comment has been minimized.
This comment has been minimized.
813b5bd to
1057181
Compare
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Split layer 4/5 from #44530. Source commit: a55ab7d Co-authored-by: 1am9trash <1am9trash@gmail.com> Co-authored-by: Alex Nails <alex.nails@radixark.ai> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com> Co-authored-by: Chunan Zeng <zcnrex@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Ethan Che <eche@meta.com> Co-authored-by: HAI <hixiao@gmail.com> Co-authored-by: HaiShaw <hixiao@gmail.com> Co-authored-by: Jiajun Li <guapisolo@gmail.com> Co-authored-by: Jiajun Li <jiajun.li@radixark.ai> Co-authored-by: Jimmy Shiu <jimmysh341@gmail.com> Co-authored-by: Jimmy Shong <69131491+Jiminator@users.noreply.github.com> Co-authored-by: Jimmy Shong <jimmysh341@gmail.com> Co-authored-by: Liangsheng Yin <lsyincs@gmail.com> Co-authored-by: Wookje Han <52435620+wookjeHan@users.noreply.github.com> Co-authored-by: Wookje Han <wookjeh@nvl72d079-T17.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d094-T17.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d157-T16.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d170-T04.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d214-T17.cm.cluster> Co-authored-by: Yuhao Yang <47235274+yhyang201@users.noreply.github.com> Co-authored-by: Yuhao Yang <yhyang201@users.noreply.github.com> Co-authored-by: Zijie Chen <300606707+zijiecode@users.noreply.github.com> Co-authored-by: ethche <ethche@gmail.com> Co-authored-by: jacky.cheng <yichiche@amd.com> Co-authored-by: jianan-gu <jianan.gu@intel.com> Co-authored-by: yhyang201 <yhyang201@users.noreply.github.com>
1057181 to
37197b7
Compare
|
Hi @Fridge003, thanks for the ROCm bring-up! A heads-up so this doesn't surprise you at rebase time: #45112 regroups
Things that changed beyond the paths:
Kernel code itself was moved byte-for-byte, so the behaviour your PR relies on is unchanged. One optional suggestion: the kernels under |
|
See #47371 |
docker/muse_spark_image/ from the image tree, adapted: * Dockerfile: the day0 image (pinned digest) with python/sglang swapped for this tree, aiter patch 05 applied to /sgl-workspace/aiter (git apply, two Python/Triton files, nothing rebuilt), and the 16-row Muse aiter bf16 GEMM CSV. No ENV lines. The build checks the editable mapping, byte-compiles the package and the patched aiter files and verifies the manifest. * prepare_context.sh <commit> <dir>: build context from one commit (git archive), plus the manifest. The two aiter files patch 05 produces are computed from the base image's own copies, so the manifest pins them too. * make_manifest.py (schema 2): tree commit, base (#44667 on main d33dd05), files changed vs #44667, sha256 of every package file, the aiter CSV, the two patched aiter files and patch 05 itself. verify_manifest.py unchanged. The CSV is force-added (*.csv is gitignored). (cherry picked from commit 58b7898) (cherry picked from commit 291384c26afeb19afce5d73024b78ea17d27c744)
Motivation
Split #44530 into five review layers. This is layer 4/5, now based on
mainafter #44666 merged.Modifications
Adds the independent ROCm runtime, AITER patches and validation records, ROCm image and launch script, plus AMD-specific changes in shared kernels, AITER attention, environment settings, and model loading. Includes the ROCm LDS optimization in moe_align_kernel.cu.
This layer changes 44 files (+11,551 / -41) relative to its immediate base. Every split commit preserves all 32
Co-authored-bytrailers from the original commit.Validation
mainatd33dd0566a1a8b77bdad83b64cbc45510307052bafter PR3 merged. Stable patch ID and range diff confirm that this layer's patch is unchanged. Preserved the AMD commit's original author, author date, message and all 32 coauthor trailers.MuseSparkTextConfig/MuseSparkTextForCausalLM, and kept only the conditional-generation architecture as the registered model entry. The ROCm model is AST-equivalent after these mechanical name/entry updates.Stack
Merge/review order, from
mainupward:The original #44530 remains unchanged as the full-stack reference.
CI States
Latest PR Test (Base): ❌ Run #39109929535
Latest PR Test (Extra): ❌ Run #39109929490
Latest PR Test (AMD ROCm 10): ❌ Run #39109929504