Skip to content

[Perf] kernels: Add muse spark Helion speculative verify megakernels - #44668

Draft
Fridge003 wants to merge 1 commit into
codex/muse-spark-stack-04-amdfrom
codex/muse-spark-stack-05-helion-verify
Draft

Fridge003 wants to merge 1 commit into
codex/muse-spark-stack-04-amdfrom
codex/muse-spark-stack-05-helion-verify

Conversation

@Fridge003

@Fridge003 Fridge003 commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Split #44530 into five review layers. This is layer 5/5, based on #44667.

Modifications

Validation

  • Rebase validation: Python compilation passed for all 21 Python files in this layer; pre-commit and git diff --check passed. No GPU tests were rerun for this rebase.
  • Rebased onto PR4 at 37197b72708c0bc6f89c5c54a1719df22455613c after PR3 merged into main. Stable patch ID and range diff confirm that this layer's patch is unchanged. Preserved the Helion commit's original author, author date, message and all 32 coauthor trailers.
  • Migrated this layer's TP/MoE-TP reads to get_parallel() and updated its test fixture so it remains compatible with PR3's runtime-context guard. Reviewed the range diff to retain only this layer's changes.
  • Prior validation: all 11 Helion integration unit tests passed in an isolated Linux checkout. Python compilation passed for all 21 files in this layer; pre-commit and the complete parallel-accessor source guard passed. Helion GPU kernel/performance suites were not rerun.

Stack

Merge/review order, from main upward:

  1. #44664 — CUDA Docker and DeepGEMM patches (merged)
  2. #44665 — Kernels and collective GEMM (merged)
  3. #44666 — SRT and registered tests (merged)
  4. #44667 — AMD / ROCm support
  5. #44668 — Helion verify megakernels (Add SSL Cert Functionality #224)

The original #44530 remains unchanged as the full-stack reference.


CI States

Latest PR Test (Base): 🚫 Run #39109929361
Latest PR Test (Extra): 🚫 Run #39109929372
Latest PR Test (AMD ROCm 10): 🚫 Run #39109929369

@Fridge003 Fridge003 changed the title [MuseSpark][5/5] Add Helion speculative verify megakernels [Feat] Add Helion speculative verify megakernels Oct 16, 2026
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch from 046cd52 to caf6b36 Compare October 16, 2026 06:29
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch 2 times, most recently from 51abebf to e297cab Compare October 16, 2026 06:51
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch 2 times, most recently from cbd25ea to 2994494 Compare October 16, 2026 20:50
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch from e297cab to 10151d3 Compare October 16, 2026 20:50
@github-actions

This comment has been minimized.

@ethche

ethche commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@Fridge003 Please try with #44798 if there is a perf regression. Thanks!

@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch from 2994494 to 5190238 Compare October 18, 2026 04:51
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch from 10151d3 to 2352216 Compare October 18, 2026 04:52
@github-actions

This comment has been minimized.

@Fridge003 Fridge003 changed the title [Feat] Add Helion speculative verify megakernels [Perf] kernels: Add muse spark Helion speculative verify megakernels (5/5) Oct 18, 2026
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch from 5190238 to 813b5bd Compare October 18, 2026 05:15
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch from 2352216 to 94550c5 Compare October 18, 2026 05:15
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch from 813b5bd to 1057181 Compare October 18, 2026 07:57
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch from 94550c5 to 90c02c0 Compare October 18, 2026 07:58
Split layer 5/5 from #44530.
Source commit: a55ab7d

Co-authored-by: 1am9trash <1am9trash@gmail.com>
Co-authored-by: Alex Nails <alex.nails@radixark.ai>
Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com>
Co-authored-by: Chunan Zeng <zcnrex@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: Ethan Che <eche@meta.com>
Co-authored-by: HAI <hixiao@gmail.com>
Co-authored-by: HaiShaw <hixiao@gmail.com>
Co-authored-by: Jiajun Li <guapisolo@gmail.com>
Co-authored-by: Jiajun Li <jiajun.li@radixark.ai>
Co-authored-by: Jimmy Shiu <jimmysh341@gmail.com>
Co-authored-by: Jimmy Shong <69131491+Jiminator@users.noreply.github.com>
Co-authored-by: Jimmy Shong <jimmysh341@gmail.com>
Co-authored-by: Liangsheng Yin <lsyincs@gmail.com>
Co-authored-by: Wookje Han <52435620+wookjeHan@users.noreply.github.com>
Co-authored-by: Wookje Han <wookjeh@nvl72d079-T17.cm.cluster>
Co-authored-by: Wookje Han <wookjeh@nvl72d094-T17.cm.cluster>
Co-authored-by: Wookje Han <wookjeh@nvl72d157-T16.cm.cluster>
Co-authored-by: Wookje Han <wookjeh@nvl72d170-T04.cm.cluster>
Co-authored-by: Wookje Han <wookjeh@nvl72d214-T17.cm.cluster>
Co-authored-by: Yuhao Yang <47235274+yhyang201@users.noreply.github.com>
Co-authored-by: Yuhao Yang <yhyang201@users.noreply.github.com>
Co-authored-by: Zijie Chen <300606707+zijiecode@users.noreply.github.com>
Co-authored-by: ethche <ethche@gmail.com>
Co-authored-by: jacky.cheng <yichiche@amd.com>
Co-authored-by: jianan-gu <jianan.gu@intel.com>
Co-authored-by: yhyang201 <yhyang201@users.noreply.github.com>
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-05-helion-verify branch from 90c02c0 to ecf68d3 Compare October 18, 2026 08:02
@Fridge003
Fridge003 force-pushed the codex/muse-spark-stack-04-amd branch from 1057181 to 37197b7 Compare October 18, 2026 08:02
@BBuf

BBuf commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Hi @Fridge003, thanks for the Helion verify megakernels! A heads-up for the rebase: #45112 regroups sglang.kernels by operator, following the existing README rule that model-specific kernels live inside a logical group rather than in a model-named top-level group. As part of that, python/sglang/kernels/ops/muse_spark/ was dissolved. For this PR:

  • helion_qk_norm.py → ops/attention/muse_spark_qk_norm_rope_store_helion.py
  • helion_runtime.py → kernels/jit/utils/helion_runtime.py
    • helion_supported(tensor) no longer takes op_name.
    • The public helpers are base_package_version and warn_helion_unsupported.
  • FinalizePushWorkspace now lives in srt/layers/communication/muse_spark_finalize_workspace.py. The moe modules this PR edits import it from there.
  • helion_megakernels/ and its tests need a home in a logical group. test_kernels_namespace.py now checks that the operator groups match the README list, so ops/muse_spark/ and test/registered/kernels/ops/muse_spark/ would be rejected. Since these are whole-layer speculative-verify kernels, ops/speculative/ (e.g. ops/speculative/muse_spark_helion_verify/, with tests under test/registered/kernels/ops/speculative/) seems like a natural fit, but I'm open to whatever you think reads best.

Kernel code was moved byte-for-byte, so nothing should change functionally. Happy to help with the rebase if that's useful. Thanks!

@Fridge003 Fridge003 changed the title [Perf] kernels: Add muse spark Helion speculative verify megakernels (5/5) [Perf] kernels: Add muse spark Helion speculative verify megakernels Oct 19, 2026
@Fridge003
Fridge003 marked this pull request as draft October 28, 2026 21:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants