Repository navigation
Conversation
Fridge003
requested review from
Alisehen,
AniZpZ,
BBuf,
DarkSharpness,
Edwardf0t1,
FlamingoPg,
HaiShaw,
HydraQYH,
OrangeRedeng,
Ying1123,
b8zhong,
celve,
ch-wan,
ispobock,
merrymercy,
mmangkad and
yuan-luo
as code owners
October 16, 2026 04:44
This was referenced Oct 16, 2026
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 16, 2026 05:20
a2c37f0 to
046cd52
Compare
Fridge003
requested review from
JustinTong0323,
Qiaolin-Yu,
hnyls2002,
mickqian and
yizhang2077
as code owners
October 16, 2026 05:20
2 of 9 tasks
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 16, 2026 06:29
046cd52 to
caf6b36
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
2 times, most recently
from
October 16, 2026 06:51
51abebf to
e297cab
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
2 times, most recently
from
October 16, 2026 20:50
cbd25ea to
2994494
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
from
October 16, 2026 20:50
e297cab to
10151d3
Compare
This comment has been minimized.
This comment has been minimized.
5 tasks done
Contributor
|
@Fridge003 Please try with #44798 if there is a perf regression. Thanks! |
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 18, 2026 04:51
2994494 to
5190238
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
from
October 18, 2026 04:52
10151d3 to
2352216
Compare
This comment has been minimized.
This comment has been minimized.
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 18, 2026 05:15
5190238 to
813b5bd
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
from
October 18, 2026 05:15
2352216 to
94550c5
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 18, 2026 07:57
813b5bd to
1057181
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
from
October 18, 2026 07:58
94550c5 to
90c02c0
Compare
Split layer 5/5 from #44530. Source commit: a55ab7d Co-authored-by: 1am9trash <1am9trash@gmail.com> Co-authored-by: Alex Nails <alex.nails@radixark.ai> Co-authored-by: Baizhou Zhang <sobereddiezhang@gmail.com> Co-authored-by: Chunan Zeng <zcnrex@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Ethan Che <eche@meta.com> Co-authored-by: HAI <hixiao@gmail.com> Co-authored-by: HaiShaw <hixiao@gmail.com> Co-authored-by: Jiajun Li <guapisolo@gmail.com> Co-authored-by: Jiajun Li <jiajun.li@radixark.ai> Co-authored-by: Jimmy Shiu <jimmysh341@gmail.com> Co-authored-by: Jimmy Shong <69131491+Jiminator@users.noreply.github.com> Co-authored-by: Jimmy Shong <jimmysh341@gmail.com> Co-authored-by: Liangsheng Yin <lsyincs@gmail.com> Co-authored-by: Wookje Han <52435620+wookjeHan@users.noreply.github.com> Co-authored-by: Wookje Han <wookjeh@nvl72d079-T17.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d094-T17.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d157-T16.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d170-T04.cm.cluster> Co-authored-by: Wookje Han <wookjeh@nvl72d214-T17.cm.cluster> Co-authored-by: Yuhao Yang <47235274+yhyang201@users.noreply.github.com> Co-authored-by: Yuhao Yang <yhyang201@users.noreply.github.com> Co-authored-by: Zijie Chen <300606707+zijiecode@users.noreply.github.com> Co-authored-by: ethche <ethche@gmail.com> Co-authored-by: jacky.cheng <yichiche@amd.com> Co-authored-by: jianan-gu <jianan.gu@intel.com> Co-authored-by: yhyang201 <yhyang201@users.noreply.github.com>
Fridge003
force-pushed
the
codex/muse-spark-stack-05-helion-verify
branch
from
October 18, 2026 08:02
90c02c0 to
ecf68d3
Compare
Fridge003
force-pushed
the
codex/muse-spark-stack-04-amd
branch
from
October 18, 2026 08:02
1057181 to
37197b7
Compare
5 tasks done
Collaborator
|
Hi @Fridge003, thanks for the Helion verify megakernels! A heads-up for the rebase: #45112 regroups
Kernel code was moved byte-for-byte, so nothing should change functionally. Happy to help with the rebase if that's useful. Thanks! |
Fridge003
marked this pull request as draft
October 28, 2026 21:18
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split #44530 into five review layers. This is layer 5/5, based on #44667.
Modifications
Validation
git diff --checkpassed. No GPU tests were rerun for this rebase.37197b72708c0bc6f89c5c54a1719df22455613cafter PR3 merged intomain. Stable patch ID and range diff confirm that this layer's patch is unchanged. Preserved the Helion commit's original author, author date, message and all 32 coauthor trailers.get_parallel()and updated its test fixture so it remains compatible with PR3's runtime-context guard. Reviewed the range diff to retain only this layer's changes.Stack
Merge/review order, from
mainupward:The original #44530 remains unchanged as the full-stack reference.
CI States
Latest PR Test (Base): 🚫 Run #39109929361
Latest PR Test (Extra): 🚫 Run #39109929372
Latest PR Test (AMD ROCm 10): 🚫 Run #39109929369