Repository navigation
Conversation
alexnails
requested review from
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
celve and
yuan-luo
as code owners
October 17, 2026 14:33
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 17, 2026
…6-gelu-mul-lut # Conflicts: # python/sglang/kernels/ops/activation/__init__.py
This was referenced Nov 9, 2026
airMeng
pushed a commit
to airMeng/sglang
that referenced
this pull request
Nov 16, 2026
airMeng
pushed a commit
to airMeng/sglang
that referenced
this pull request
Nov 17, 2026
airMeng
pushed a commit
to airMeng/sglang
that referenced
this pull request
Nov 18, 2026
airMeng
added a commit
to airMeng/sglang
that referenced
this pull request
Nov 18, 2026
Mechanical compatibility with main CI suite renaming in sgl-project#50874. Retain the original one-GPU extra and four-GPU nightly assignments. Sources: sgl-project#44905, sgl-project#48374, sgl-project#43891.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sglang.kernels.ops.activation.bf16_gelu_tanh_mul_lut, an inference-only Triton XPU operator for BF16[gate, up]matrices. It indexes a caller-owned 65,536-entry BF16 table by the gate's raw bits, then multiplies the looked-up native GELU result byupwith FP32 opmath and BF16 output rounding. This retains the native BF16 activation intermediate and leaves GEMMs and model weights unchanged.The namespace entry is lazy, and the wrapper supports fullgraph compilation and XPU graph replay. Guards enforce contiguous BF16 inputs/table on one XPU, inference-only use, the table size, and the 32-bit addressing limit; empty outputs are supported. The caller owns table construction and lifetime. A following Gemma4 integration supplies a table populated through the existing native activation.
Stacked on #44890 (
797dbef49803cd37f4da51383b0e9188e427f439). This GELU value table is separate from that PR's softcap comparison-rank table.Validation on Arc Pro B70 with Torch 2.13.0+xpu:
Reproducible local evidence: activation archive SHA256
1ff500da6df7651c695fae0f562394ab58463fa95d5817dd351a79e2ff355ae8; final-source validation/serving evidence SHA256540cda67f3025997d61bc8e2b0192dac8d45d9c873e485491021ef09aea366dd(96 files independently verified). Source commit:c6b2000ff43c503cfcf530b5cb9a77e36e797012.Additional diagnostic evidence: same-input serving oracle SHA256
cba522973e782bf4d088b3c7d4990d6c9d5af7f759ee978eca317aaf42c1dd67(19 files / all 6,300 ordered checks independently verified); serialized quality evidence SHA256e3efbfb804d5829296c19d59b14b047d5f789e95669242409b3d8365d7bf0ead(30 files independently verified).CI States
Latest PR Test (Base): ❌ Run #42143750050
Latest PR Test (Extra): ❌ Run #42143749979
Latest PR Test (AMD ROCm 10): ❌ Run #42143750085
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: