Repository navigation
[CI] suites: Unify CI suite and command names, skip instead of fail without run-ci, and share one finish-job check - #50874
Merged
Merged
Conversation
hnyls2002
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock,
merrymercy and
michaelzhang-ai
as code owners
November 17, 2026 00:53
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This comment has been minimized.
This comment has been minimized.
hnyls2002
requested review from
JustinTong0323,
sogalin,
wisclmy0611 and
zijiexia
as code owners
November 17, 2026 08:16
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
…<runner>[-<hw>]; merge xeon/xpu stage pairs; drop never-run npu tests
…l by stage kind; drop diffusion-* runner configs
…; drop default require-run-ci; link ci command docs
hnyls2002
force-pushed
the
lsyin/ci-simplify-hw-workflows
branch
from
November 17, 2026 08:23
09c5569 to
90583b9
Compare
This comment has been minimized.
This comment has been minimized.
michaelzhang-ai
added a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Nov 17, 2026
Resolve the test/run_suite.py conflict from the suite renames in sgl-project#50874, and rename the MMMU suite to the new scheme: nightly-accuracy-test-8-gpu-amd-mi35x-muse-spark-mmmu.
rbrugaro-amd
added a commit
to rbrugaro-amd/sglang
that referenced
this pull request
Nov 17, 2026
…MI35x suite sgl-project#50874 renamed the CI suites from stage-* to base-*, so stage-c-test-large-8-gpu-amd-mi35x no longer exists and no workflow ran this test; the check-registered-tests hook now rejects it. Register it in base-c-test-large-8-gpu-amd-mi35x, which pr-test-amd.yml runs. Signed-off-by: Rita Brugarolas Brufau <rita.brugarolasbrufau@amd.com>
rbrugaro-amd
added a commit
to rbrugaro-amd/sglang
that referenced
this pull request
Nov 17, 2026
sgl-project#50874 renamed the CI suites, and stage-b-test-1-gpu-small-amd-mi35x is now base-b-test-1-gpu-small-amd-mi35x. It migrated every test already on main, but this branch's test still named the old suite, so the check-registered-tests lint hook rejected it as registered to a suite no workflow runs. Signed-off-by: Rita Brugarolas Brufau <rita.brugarolasbrufau@amd.com>
eppaneamd
added a commit
to eppaneamd/sglang
that referenced
this pull request
Nov 17, 2026
main renamed the CI stages (sgl-project#50874); a test registered under stage-b now maps to a suite no workflow runs. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Rony Leppänen <rony.leppanen@amd.com>
airMeng
added a commit
to airMeng/sglang
that referenced
this pull request
Nov 18, 2026
Mechanical compatibility with main CI suite renaming in sgl-project#50874. Retain the original one-GPU extra and four-GPU nightly assignments. Sources: sgl-project#44905, sgl-project#48374, sgl-project#43891.
kevin-mii
added a commit
to kevin-mii/sglang
that referenced
this pull request
Nov 18, 2026
main renamed the CI suites (sgl-project#50874). test_verify_shared_kv.py conflicted on its registration line: take main's base-b suite name and keep this PR's est_time. The other registrations this PR touches move to the new names too, since a stale suite name is never dispatched.
kevin-mii
added a commit
to kevin-mii/sglang
that referenced
this pull request
Nov 18, 2026
…ites main renamed the CI suites (sgl-project#50874); a test registered under an old name is never dispatched.
kevin-mii
added a commit
to kevin-mii/sglang
that referenced
this pull request
Nov 18, 2026
Conflicts: - dflash_draft_ring.py: main (sgl-project#50740) added the MHA ring path ahead of the MLA backend check; keep it and keep this PR's dflash_draft_reads_rows_by_position in place of the DFLASH_MLA_ONLY_DRAFT_BACKENDS membership test. - test_dflash_draft_kv_ring.py: keep both main's current_platform import and this PR's override_platform import. - Registration lines in test_verify_shared_kv.py and test_fused_kda_conv_recurrent_verify.py: take main's renamed suites (sgl-project#50874) and keep this PR's est_time. The other AMD registrations this PR touches move to the new suite names too, since a stale name is never dispatched.
kevin-mii
added a commit
to kevin-mii/sglang
that referenced
this pull request
Nov 18, 2026
…ites main renamed the CI suites (sgl-project#50874); a test registered under an old name is never dispatched.
jiaryang
added a commit
to jiaryang/sglang
that referenced
this pull request
Nov 18, 2026
sgl-project#50874 renamed the AMD suite jit-kernel-unit-test-amd to base-a-jit-kernel-unit-test-amd; no workflow runs the old name. Co-Authored-By: Claude <noreply@anthropic.com>
Shunkangz
added a commit
to Shunkangz/sglang
that referenced
this pull request
Nov 18, 2026
… suite sgl-project#50874 renamed the Xeon suites stage-a/b-test-cpu-intel to extra-test-cpu-intel. sgl-project#41329 merged afterwards still registering test_quant_ops.py on stage-a-test-cpu-intel, which no workflow runs, so check-registered-tests fails on main and on every PR based on it. Move it to extra-test-cpu-intel, the suite pr-test-xeon.yml runs and every other Intel CPU kernel test under test/registered/cpu uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 5 tasks
bvolpato
added a commit
to bvolpato/sglang
that referenced
this pull request
Nov 18, 2026
The previous workflows stopped at the missing run-ci label. A fresh push picks up the upstream gate change in sgl-project#50874 so optional hardware checks can skip while base CI waits for approval.
bvolpato
added a commit
to bvolpato/sglang
that referenced
this pull request
Nov 18, 2026
Use the upstream CI gate from sgl-project#50874 and register the DSpark regression in the renamed AMD JIT kernel suite.
At1a8
added a commit
to At1a8/sglang
that referenced
this pull request
Nov 18, 2026
…y suite sgl-project#50874 renamed nightly-amd-4-gpu-mi35x-deepseek-v41-flash to nightly-test-4-gpu-amd-mi35x-deepseek-v41-flash, and test/run_suite.py lists only the new name.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #50876, #50894, and #50933, which closed when this stack was reordered, with the finish-job cleanup that was this PR. Follows #50872.
Remove duplicate commands
/run-<tier>-cicommands (/run-nv-extra-ci,/run-xeon-extra-ci,/run-nv-ci, and their/rerun-forms). They duplicate/run-ci <hardware>,/run-extra-ci <hardware>, and/run-full-ci <hardware>, which now take any number of hardware arguments./run-base-ci,/rerun-base-ci,/rerun-extra-ci,/rerun-full-ci, and/rerun-cpu-ci;/run-ci,/run-extra-ci,/run-full-ci, and/run-cpu-cido the same. Removed spellings get the usual "did you mean" reply for unknown commands. Typo suggestions now include/run-ciand/run-extra-ci..github/FOLDER_README.md, the CI workflow skill, and the opt-in tier lint's messages.Unify CI suite names across hardware
<tier>[-<stage>]-[<kind>-]test-<runner>[-<hardware>][-<variant>]. Per commit, the tier isbaseorextra: NVIDIA and AMD have both, every other hardware onlyextra. A stage letter is kept only where jobs run in stage order (NVIDIA, AMD, NPU). The rule is written down in thewrite-sglang-testskill.stage-a-test-cpu-intelandstage-b-test-cpu-intelwere always unioned into one pool, so they merge intoextra-test-cpu-intel;stage-a-tp-test-cpu-intelbecomesextra-tp-test-cpu-intel.stage-a-test-1-gpu-xpuandstage-b-test-1-gpu-xpu(also run as one pool) merge intoextra-test-1-gpu-xpu.stage-{a,b,c}-*-amdbecomesbase-{a,b,c}-*-amd, in bothsuite=andstage=registrations; the kernel suites gainbase-a-, the disaggregation suite becomesbase-b-disaggregation-test-large-8-gpu-amd-mi35x, and the stage waits becomewait-for-base-{a,b}-amd.base-*becomesextra-*(extra-c-test-acc-*asextra-c-acc-test-*), including the coverage job and artifact names and theshould_run_*/only_tests_*outputs.extra-*names.fullsuites follow the same scheme, e.g.nightly-amd-accuracy-8-gpu-mi35x-kimi-k3->nightly-accuracy-test-8-gpu-amd-mi35x-kimi-k3,nightly-acc-2-npu-a3->nightly-acc-test-2-npu-a3,nightly-xpu-kernel-main-1-gpu->nightly-kernel-main-test-1-gpu-xpu,nightly-musa-1-gpu->nightly-test-1-gpu-musa. AMD nightly job ids, which do not match suite names, are unchanged.per-commit-*-npu-a2/a3suites, which no workflow runs, and abase-b-test-17-npu-a3registration with no job (the test keeps its nightly registration).Name NVIDIA diffusion suites by kind and pick the install by stage
test:base-b-test-diffusion-1-gpu-h100becomesbase-b-diffusion-test-1-gpu-large, and thebcg,component, andunitlanes becomebase-b-diffusion-{bcg,component,unit}-test-<runner>.1-gpu-small,1-gpu-large,2-gpu-large, plus new1-gpu-b200and1-gpu-b300); the eightdiffusion-*runner configs are removed.scripts/ci/runner_configs.ymlmaps the kind's first word (diffusion) to the diffusion install throughkind_installs, andscripts/ci/runner_configs.pyresolves(runner_config, stage)._pr-test-stage.yml,_diffusion-pr-test-stage.yml, and/rerun-testuse it._diffusion-pr-test-stage.ymltakes the stage and names its job, artifacts, and suite<stage>-test-<runner_config>, since several lanes now share a runner key.test/run_suite.py,pr-test-multimodal-gen.yml, the PR test health check fixtures, and the CI skills.Share one
jqneeds check across finish jobspr-test.yml,pr-test-extra.yml,pr-test-amd.yml,pr-test-amd-extra.yml,pr-test-npu.yml,pr-test-musa.yml,pr-test-mlx.yml,pr-test-xpu.yml, andnightly-test-musa.ymlshare one check:toJson(needs)passes throughenvinstead of being pasted into a shell string,jqprints each job's result and fails onfailureorcancelled.pr-test-musa.yml: fixworkflow_dispatchinput:toinputs:, so itstarget_stageinput is accepted.pr-gate.yml'srequire-run-ciinput, which every caller left at its default..github/FOLDER_README.md: link the contribution guide for command syntax instead of repeating it; keep the permission and tier-registration rules.Skip instead of fail on a draft PR or without
run-cipr-gate.yml: a draft PR, a missingrun-ci, or a missing opt-in label runs oneSkip testsstep, and the gate passes withopted-in=falseinstead of failing. Every caller's test jobs, and its finish job, skip on it, so a skipped run shows no passing check;pr-test.yml,pr-test-amd.yml,pr-test-sgl-router.yml, andpr-test-sgl-processor.ymlnow check it too.pr-test-finish, a required check, runs and fails when the tests were skipped, so it is the only red check on such a PR (down from about 19) and the PR still cannot merge without Base CI./rerun-failed-ci(and/tag-and-rerun-ci, which calls it) fully reruns a run whose tests the gate skipped once the PR hasrun-ci, is not a draft, and has the workflow's opt-in labels; "Re-run failed jobs" would rerun onlypr-test-finish./run-ci <hardware>reruns such runs in full as well.pr-states.ymltells skipped runs from tested ones for the Base, Extra, and AMD rows, and refreshes when a PR leaves or enters draft.scripts/lint/check_opt_in_ci_tiers.pyfails when a job that needspr-gate.ymldoes not skip onopted-in; onlypr-test-finishis exempt.Fail the lint for tests no workflow runs
scripts/lint/check_registered_tests.py: a non-CUDA registration not markeddisabledfails when no workflow, action, orscripts/cishell script names its suite and none runs its file by path. CUDA suites stay covered by the existing stage/runner_config checks. The pre-commit hook now also runs on workflow andscripts/cichanges.full-test-4-npu-a2,nightly-test-17-npu-a3,nightly-test-npu-a3-merged). Tests thatnightly-test-amd.ymlruns by path are kept.test_gdn_prefill_layout.py, added on main withstage="stage-b", moves tobase-b.Behavior
/run-<tier>-ciand the command aliases above no longer run CI; use/run-ci,/run-extra-ci,/run-full-ci, or/run-cpu-ci.run-ci, every workflow skips its tests and finish job, and onlypr-test-finishfails; previously every workflow's gate failed.Skip testsstep, so/tag-and-rerun-ci <hardware>does not rerun their green opt-in runs;/run-extra-ci <hardware>or a push does.pr-test-musa.yml's dispatch input was declared underinput:, sotarget_stagewas never defined; it isinputs:now, and a manual MUSA dispatch honors it, and the XPU finish job now also fails when its gate job fails, as the other finish jobs do.pr-test-mlu.ymlpasses the suite name asSGLANG_MLU_CI_TRIGGER_TYPEto the external MLU CI, which now receivesextra-test-{1,2}-mlu. CI monitors that group runs by job name (XPU, NPU, AMD) start a new history for each renamed job. Until runs from before the rename leave its lookback window, about a week, the CI failure monitor (scripts/ci_monitor/ci_failures_analysis.py) also lists old-name jobs with the streak they had at the rename, so a job that was failing then still shows as failing.CI States
Latest PR Test (Base): ❌ Run #44064272576⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-nv-extralabel to opt in.Latest PR Test (AMD ROCm 10): ✅ Run #44064271858
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: