Skip to content

[CI] hardware: Gate non-NV/AMD hardware CI behind run-ci-<hw>-extra labels - #50872

Merged
hnyls2002 merged 4 commits into
mainfrom
lsyin/hw-ci-opt-in
Nov 17, 2026
Merged

hnyls2002 merged 4 commits into
mainfrom
lsyin/hw-ci-opt-in

Conversation

@hnyls2002

@hnyls2002 hnyls2002 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator
  • Every hardware other than NVIDIA and AMD now has a single opt-in tier, <hw>-extra: pr-test-<hw>.yml for Xeon, NPU, XPU, MUSA, ARM64, MLX, MLU, and PPU runs on a PR only with run-ci plus run-ci-<hw>-extra, and on main as before. NVIDIA and AMD keep Base plus Extra.
  • pr-gate.yml: a missing opt-in label now passes the gate with opted-in=false, and the caller's test jobs skip, so an unlabeled PR shows these workflows green instead of failed. This also applies to NVIDIA Extra and AMD Extra.
  • Xeon: remove the xeon-extra job from pr-test-extra.yml and the extra_only input, so NVIDIA Extra no longer waits on Xeon runners; the two SWA tests move back from extra-test-cpu-intel to stage-b-test-cpu-intel.
  • MLX: add a push: main trigger, so it keeps coverage on main once PR runs are opt-in.
  • MLU and PPU labels are renamed to run-ci-mlu-extra and run-ci-ppu-extra.
  • Slash commands: /run-ci, /run-extra-ci, /run-full-ci, /tag-run-ci-label, /tag-and-rerun-ci and their aliases take any number of hardware arguments (nv, amd, xeon, npu, xpu, musa, arm64, mlx, mlu, ppu), e.g. /run-ci xeon npu or /run-extra-ci nv amd. For hardware without a Base tier, /run-ci <hw> runs its Extra tier. /tag-and-rerun-ci <hw> also reruns that hardware's runs that passed without the label. Unknown arguments are rejected.
  • pr-states.yml: the CI states block in the PR body shows a green PR Test Extra run with every test job skipped as not run, instead of a pass.
  • Docs: contribution guides, .github/FOLDER_README.md, and the CI skills.

Behavior change: Xeon, NPU, XPU, MUSA, ARM64, and MLX CI no longer runs on every PR with run-ci; opt in with /run-ci <hw>.


CI States

Latest PR Test (Base): 🚫 Run #44044674858
Latest PR Test (Extra): ⚠️ Not enabled -- add run-ci-nv-extra label to opt in.
Latest PR Test (AMD ROCm 10): 🚫 Run #44044674936

Tip

Base CI only covers the core cases, and its workload may not exercise your change. Use /rerun-test to run the tests your change touches, or copy this prompt for an agent:

Find the registered tests this PR affects and run them with /rerun-test, following https://github.com/sgl-project/sglang/blob/main/.agents/skills/rerun-test/SKILL.md

…d of fail without the label; take hardware args in every run-ci command

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mintlify

mintlify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
sglang-doc 🟢 Ready View Preview Nov 17, 2026, 8:14 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

This comment has been minimized.

…th every test skipped as not run in the CI states block
@hnyls2002 hnyls2002 added the run-ci CI: run the baseline test suite on this PR label Nov 17, 2026
@hnyls2002
hnyls2002 merged commit ba93265 into main Nov 17, 2026
117 of 132 checks passed

This branch was successfully deployed

1 active deployment
staging - docs — d120dee0 Deployed Nov 17, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd apple-silicon documentation Improvements or additions to documentation mthreads npu run-ci CI: run the baseline test suite on this PR unified-radix-cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant