Repository navigation
[CI] hardware: Gate non-NV/AMD hardware CI behind run-ci-<hw>-extra labels - #50872
Merged
Merged
Conversation
…d of fail without the label; take hardware args in every run-ci command
hnyls2002
requested review from
Fridge003,
HaiShaw,
JustinTong0323,
Kangyan-Zhou,
bingxche,
ispobock,
merrymercy,
michaelzhang-ai,
sogalin,
wisclmy0611 and
zijiexia
as code owners
November 17, 2026 00:49
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This comment has been minimized.
This comment has been minimized.
…th every test skipped as not run in the CI states block
… as passing only when its tests ran
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<hw>-extra:pr-test-<hw>.ymlfor Xeon, NPU, XPU, MUSA, ARM64, MLX, MLU, and PPU runs on a PR only withrun-ciplusrun-ci-<hw>-extra, and onmainas before. NVIDIA and AMD keep Base plus Extra.pr-gate.yml: a missing opt-in label now passes the gate withopted-in=false, and the caller's test jobs skip, so an unlabeled PR shows these workflows green instead of failed. This also applies to NVIDIA Extra and AMD Extra.xeon-extrajob frompr-test-extra.ymland theextra_onlyinput, so NVIDIA Extra no longer waits on Xeon runners; the two SWA tests move back fromextra-test-cpu-inteltostage-b-test-cpu-intel.push: maintrigger, so it keeps coverage onmainonce PR runs are opt-in.run-ci-mlu-extraandrun-ci-ppu-extra./run-ci,/run-extra-ci,/run-full-ci,/tag-run-ci-label,/tag-and-rerun-ciand their aliases take any number of hardware arguments (nv,amd,xeon,npu,xpu,musa,arm64,mlx,mlu,ppu), e.g./run-ci xeon npuor/run-extra-ci nv amd. For hardware without a Base tier,/run-ci <hw>runs its Extra tier./tag-and-rerun-ci <hw>also reruns that hardware's runs that passed without the label. Unknown arguments are rejected.pr-states.yml: the CI states block in the PR body shows a green PR Test Extra run with every test job skipped as not run, instead of a pass..github/FOLDER_README.md, and the CI skills.Behavior change: Xeon, NPU, XPU, MUSA, ARM64, and MLX CI no longer runs on every PR with
run-ci; opt in with/run-ci <hw>.CI States
Latest PR Test (Base): 🚫 Run #44044674858⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-nv-extralabel to opt in.Latest PR Test (AMD ROCm 10): 🚫 Run #44044674936
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: