Skip to content

Enable Shakapacker early hints #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
+1,363 −1,341
Open

Enable Shakapacker early hints #687

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8731438
Changes auto-committed by Conductor
justin808 Oct 17, 2025
a810cca
Fix Ruby version mismatch for CI
justin808 Oct 17, 2025
9fca254
Add postinstall script to build shakapacker from GitHub branch
justin808 Oct 17, 2025
eb1b3be
Update lock files for shakapacker branch changes
justin808 Oct 17, 2025
9930aaf
Enable early hints debug mode
justin808 Oct 17, 2025
395b7a4
Update shakapacker to latest from early-hints branch
justin808 Oct 17, 2025
58f9d8e
Update shakapacker to latest from early-hints branch
justin808 Oct 17, 2025
8082229
Update shakapacker to latest from early-hints branch
justin808 Oct 17, 2025
0104fb1
Enable Puma early hints support in all Procfiles
justin808 Oct 17, 2025
56d2a68
Keep --early-hints only for production and testing
justin808 Oct 17, 2025
b6255d5
Enable early hints in Control Plane production deployment
justin808 Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
ruby "3.4.6"

gem "react_on_rails", "16.1.1"
gem "shakapacker", "9.3.0.beta.2"
gem "shakapacker", github: "shakacode/shakapacker", branch: "justin808/early-hints"

# Bundle edge Rails instead: gem "rails", github: "rails/rails"
gem "listen"
Expand Down
22 changes: 14 additions & 8 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
GIT
remote: https://github.com/shakacode/shakapacker.git
revision: 6bf6bf5c21388a402362c516370606529d6cfecd
branch: justin808/early-hints
specs:
shakapacker (9.3.0.beta.2)
activesupport (>= 5.2)
package_json
rack-proxy (>= 0.6.1)
railties (>= 5.2)
semantic_range (>= 2.3.0)

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -386,12 +398,6 @@ GEM
websocket (~> 1.0)
semantic_range (3.1.0)
sexp_processor (4.17.1)
shakapacker (9.3.0.beta.2)
activesupport (>= 5.2)
package_json
rack-proxy (>= 0.6.1)
railties (>= 5.2)
semantic_range (>= 2.3.0)
simplecov (0.21.2)
docile (~> 1.1)
simplecov-html (~> 0.11)
Expand Down Expand Up @@ -496,7 +502,7 @@ DEPENDENCIES
scss_lint
sdoc
selenium-webdriver (~> 4)
shakapacker (= 9.3.0.beta.2)
shakapacker!
spring
spring-commands-rspec
stimulus-rails (~> 1.3)
Expand All @@ -505,7 +511,7 @@ DEPENDENCIES
web-console

RUBY VERSION
ruby 3.4.6p32
ruby 3.4.6p54

BUNDLED WITH
2.4.17
4 changes: 4 additions & 0 deletions config/shakapacker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,7 @@ production:

# Cache manifest.json for performance
cache_manifest: true

# Early hints configuration
early_hints:
enabled: true
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"homepage": "https://github.com/shakacode/react-webpack-rails-tutorial",
"scripts": {
"postinstall": "patch-package",
"postinstall": "patch-package && if [ -f node_modules/shakapacker/package/index.ts ] && [ ! -f node_modules/shakapacker/package/index.js ]; then cd node_modules/shakapacker && yarn install --production=false && yarn build; fi",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Postinstall script uses Unix shell syntax; will not work on Windows.

The postinstall script uses bash conditionals and Unix paths that will fail on Windows systems (even with Git Bash). If this project supports Windows developers, this needs a cross-platform solution (e.g., using Node.js scripts or a cross-platform shell runner like cross-env).

Consider refactoring this into a Node.js script or using a tool like node-shell-script or platform-specific fallbacks. Alternatively, document that Windows developers must use WSL.

"res:clean": "rescript clean",
"res:format": "rescript format -all",
"res:dev": "yarn res:clean && rescript build -w",
Expand Down Expand Up @@ -92,7 +92,7 @@
"sass": "^1.58.3",
"sass-loader": "^13.3.2",
"sass-resources-loader": "^2.2.5",
"shakapacker": "9.3.0-beta.2",
"shakapacker": "github:shakacode/shakapacker#justin808/early-hints",
"stimulus": "^3.0.1",
"style-loader": "^3.3.1",
"swc-loader": "^0.2.6",
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9135,10 +9135,9 @@ [email protected]:
resolved "https://registry.npmjs.org/setprototypeof/-/setprototypeof-1.2.0.tgz"
integrity sha512-E5LDX7Wrp85Kil5bhZv46j8jOeboKq5JMmYM3gVGdGH8xFpPWXUMsNrlODCrkoxMEeNi/XZIwuRvY4XNwYMJpw==

shakapacker@9.3.0-beta.2:
"shakapacker@github:shakacode/shakapacker#justin808/early-hints":
version "9.3.0-beta.2"
resolved "https://registry.npmjs.org/shakapacker/-/shakapacker-9.3.0-beta.2.tgz#32d8c2b1009d81ea572c0e647deb5f295a22e591"
integrity sha512-c2v26Tie0szh+34PZBpcL+luVgVFxtvtu8GtXK6+9DDcI2BJ2h/o9iyGemIHIHo48v7+vdTiicbqkYDq/EpQtA==
resolved "https://codeload.github.com/shakacode/shakapacker/tar.gz/6bf6bf5c21388a402362c516370606529d6cfecd"
dependencies:
js-yaml "^4.1.0"
path-complete-extname "^1.0.0"
Expand Down