Skip to content

1817-update-dependencies-and-underlining-node-version-from-1418-to-22#1818

Merged
mattelen merged 16 commits intomasterfrom
1817-update-dependencies-and-underlining-node-version-from-1418-to-22
Jan 20, 2025
Merged

1817-update-dependencies-and-underlining-node-version-from-1418-to-22#1818
mattelen merged 16 commits intomasterfrom
1817-update-dependencies-and-underlining-node-version-from-1418-to-22

Conversation

@mattelen
Copy link
Copy Markdown
Collaborator

@mattelen mattelen commented Jan 2, 2025

Fixes #1817

Notes:

  • Moved the @mousedown.prevent from the Tag Slot, as a result of a ESlint complaint. This indicates that this wasn't actually be applied. How this is applied has been moved. This could result in changes of behaviour of instances where a custom tag slot is used, so worth checking everything still works
  • Includes a migration away from node-sass to sass. This means new SASS rules, so an automatic migration has occurred on that
  • Shiki got updated too, so there are many files that have changed, but have come straight from the package. These files get committed as they built the documentation site

@mattelen mattelen self-assigned this Jan 2, 2025
@mattelen mattelen linked an issue Jan 2, 2025 that may be closed by this pull request
@mattelen mattelen requested a review from akki-jat January 7, 2025 11:57
@mattelen
Copy link
Copy Markdown
Collaborator Author

mattelen commented Jan 7, 2025

@akki-jat not too sure if you'd rather wait for your accessibility changes to merge first, or if you don't mind this going in before - up to you

Also, I'm thinking we'll do a minor release with these changes, as while nothing really has changed, its more of a "worth double checking" everything still works with developers update their packages, because our internal tooling as changed. You can see I've created a milestone for it here: https://github.com/shentao/vue-multiselect/milestone/6

@akki-jat
Copy link
Copy Markdown
Collaborator

akki-jat commented Jan 7, 2025

@mattelen let's go with accessibility changes first. I will open PR soon.

…ode-version-from-1418-to-22

# Conflicts:
#	package-lock.json
@mattelen
Copy link
Copy Markdown
Collaborator Author

@akki-jat wanna re-review this please. Thanks

@mattelen mattelen merged commit 3ec51ba into master Jan 20, 2025
@mattelen mattelen deleted the 1817-update-dependencies-and-underlining-node-version-from-1418-to-22 branch January 20, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update dependencies and underlining Node version from 14.18 to 22

2 participants