Conversation
Collaborator
Author
|
@akki-jat not too sure if you'd rather wait for your accessibility changes to merge first, or if you don't mind this going in before - up to you Also, I'm thinking we'll do a minor release with these changes, as while nothing really has changed, its more of a "worth double checking" everything still works with developers update their packages, because our internal tooling as changed. You can see I've created a milestone for it here: https://github.com/shentao/vue-multiselect/milestone/6 |
Collaborator
|
@mattelen let's go with accessibility changes first. I will open PR soon. |
…ode-version-from-1418-to-22 # Conflicts: # package-lock.json
Collaborator
Author
|
@akki-jat wanna re-review this please. Thanks |
akki-jat
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817
Notes:
@mousedown.preventfrom the Tag Slot, as a result of a ESlint complaint. This indicates that this wasn't actually be applied. How this is applied has been moved. This could result in changes of behaviour of instances where a custom tag slot is used, so worth checking everything still works