Skip to content

Null selected on taggable throws exception.#37

Merged
shentao merged 2 commits intoshentao:masterfrom
asvae:null-search-fix
Jun 23, 2016
Merged

Null selected on taggable throws exception.#37
shentao merged 2 commits intoshentao:masterfrom
asvae:null-search-fix

Conversation

@asvae
Copy link
Copy Markdown
Contributor

@asvae asvae commented Jun 20, 2016

I'm getting an exception, that occurs when I pass down from parent selected, which is null.
Multiselect is taggable.
He're the exception:

app-cd1a3cff48.js:49506 [Vue warn]: Error when evaluating expression "
function () {
    var t = this.hideSelected ? this.options.filter(this.isNotSelected) : this.options;
    return t = this.$options.filters.filterBy(t, this.search), this.taggable && this.search.length > 0 && !this.isExistingOption(this.search) && t.unshift({ isTag: !0, label: this.search }), t;
        }
": TypeError: Cannot read property 'length' of null (found in component: <multiselect>)

Pull request fixes the issue.

@shentao shentao merged commit 9a0d7aa into shentao:master Jun 23, 2016
@shentao
Copy link
Copy Markdown
Owner

shentao commented Jun 23, 2016

Merged and made some small adjustments myself. Also added a test case for it. Thanks a lot @asvae! :)

shentao pushed a commit that referenced this pull request Jun 23, 2016
@asvae asvae deleted the null-search-fix branch June 24, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants