Skip to content

Conversation

rxinui
Copy link
Contributor

@rxinui rxinui commented Apr 26, 2025

Changes

Fixes #129

Migration from Hugo:Docsy to Hugo:Lotus-Docs (see https://lotusdocs.dev)

Disclaimer: I am neither a frontend developer nor a designer. This is actually my first experience with Hugo, so please bear with me...

🚀 LIVE DEMO ON GITHUB PAGES Note: the netlify preview drifts from how it should be, please use this github pages link instead.

The primary focus has been on the homepage (also known as data/landing.yaml). Beyond the new user interface, the intention of the homepage has shifted to better describe shipwright.io and make it appealing to future end-users and developers.

⚠️ Please note that the current content is not final and reflects my vision of Shipwright. It should be adjusted according to the maintainers' preferences.

In my opinion, what was lacking on the shipwright.io website was a clear purpose for end-users, highlighting the benefits and interests they could gain from the project. Therefore, the landing page is structured as follows:

  1. Hero Section: Features an image of a terminal displaying a Build YAML file. The goal is to immediately showcase Shipwright's capabilities. Since Build is a core component, I thought it was an ideal illustration. Alternatively, this image could be replaced with an architectural diagram of Shipwright + K8s + Tekton. Because "shipwright" is related to maritime world, I have designed an artsy interpretation of waves (as shipwright will make waves into the CNCF landscape!!)

  2. Why Shipwright.io: Highlights the project's features - such as Vitess.io did.

  3. Step-by-Step Overview: Demonstrates how easy it is to use Shipwright. It introduces the main components—BuildStrategy, Build, and BuildRun—in a logical sequence, with illustrations to aid comprehension. This section is inspired by ArgoProj.

  4. Footer: Utilizes another CNCF logo available from their GitHub repository. Since Shipwright is a sandbox project, I thought it would be fitting to use the corresponding banner.

Inspiration has been drawn from other CNCF project websites, such as:

All images are created by me, except for the logos from CNCF projects. The repository structure is simplified by Lotus-Docs, offering additional functionalities such as FlexSearch, DocSearch, MermaidJS, and Google Analytics. However, these functionalities are not fully implemented or configured, as they are not the focus of this issue.

What has not been done

Submitter Checklist

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Migrate to hugo:lotus-docs

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2025
@rxinui
Copy link
Contributor Author

rxinui commented Apr 26, 2025

@rxinui
Copy link
Contributor Author

rxinui commented Apr 27, 2025

Update: mobile version is now fixed. Replace all .svg to .png for bootstrapv5 to auto-resize correctly.

@rxinui
Copy link
Contributor Author

rxinui commented Apr 30, 2025

@adambkaplan i remove the typo shipwright.io --> shipwright as requested.
Also updated the diagram per @HeavyWombat request.

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start here!

That said, I'm concerned with the volume of changes here that appear to be outside the scope of adopting the new theme. This is hindering my ability to debug the preview deployment (ex: broken or missing nav links).

I may try to follow along and re-implement the migration.

Copy link
Contributor Author

@rxinui rxinui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let some comments and corrected my mistakes.

@adambkaplan
Copy link
Member

After giving an initial stab at my own "minimal" migration of the site to LotusDocs, I uncovered a bit of tech debt that can be addressed right away, related to the imgproc shortcode. See #163

@rxinui
Copy link
Contributor Author

rxinui commented Apr 30, 2025

@adambkaplan i fix the broken links !!! You can try it out on the preview.

Basically, hugo.yaml has baseURL: field which obviously is set to shipwright.io hence explain why the preview append the relative path of the docs to shipwright.io which induces the redirection to the old docs.

Now I comment it, but we can also put it back as when it will be merged, this won't have any side effect.

@rxinui
Copy link
Contributor Author

rxinui commented May 1, 2025

@SaschaSchwarze0 changes requested are now effective

@rxinui
Copy link
Contributor Author

rxinui commented May 5, 2025

@SaschaSchwarze0 typo on codye.png is fixed. To issue it, I use the free version of Codye available on MacOS. Nice for Powerpoint talks.

@rxinui
Copy link
Contributor Author

rxinui commented May 11, 2025

Any more blockers on this one @SaschaSchwarze0 @adambkaplan ?

- new: landing page uses lotusdocs hugo template

Signed-off-by: rxinui <[email protected]>
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Let's go!

Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bdf2906 into shipwright-io:main May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhance UI and functionality of the landing page and integrate docs and blogs into a docusaurus project to enhance docs capabilities
4 participants