-
Notifications
You must be signed in to change notification settings - Fork 29
Rework of shipwright.io website using hugo:lotus-docs #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC: @adambkaplan Following-up slack thread https://kubernetes.slack.com/archives/C019ZRGUEJC/p1745581312832979 |
Update: mobile version is now fixed. Replace all |
@adambkaplan i remove the typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start here!
That said, I'm concerned with the volume of changes here that appear to be outside the scope of adopting the new theme. This is hindering my ability to debug the preview deployment (ex: broken or missing nav links).
I may try to follow along and re-implement the migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let some comments and corrected my mistakes.
After giving an initial stab at my own "minimal" migration of the site to LotusDocs, I uncovered a bit of tech debt that can be addressed right away, related to the |
@adambkaplan i fix the broken links !!! You can try it out on the preview. Basically, hugo.yaml has Now I comment it, but we can also put it back as when it will be merged, this won't have any side effect. |
@SaschaSchwarze0 changes requested are now effective |
@SaschaSchwarze0 typo on codye.png is fixed. To issue it, I use the free version of Codye available on MacOS. Nice for Powerpoint talks. |
Any more blockers on this one @SaschaSchwarze0 @adambkaplan ? |
- new: landing page uses lotusdocs hugo template Signed-off-by: rxinui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Let's go!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #129
Migration from Hugo:Docsy to Hugo:Lotus-Docs (see https://lotusdocs.dev)
Disclaimer: I am neither a frontend developer nor a designer. This is actually my first experience with Hugo, so please bear with me...
🚀 LIVE DEMO ON GITHUB PAGES Note: the netlify preview drifts from how it should be, please use this github pages link instead.
The primary focus has been on the homepage (also known as
data/landing.yaml
). Beyond the new user interface, the intention of the homepage has shifted to better describe shipwright.io and make it appealing to future end-users and developers.In my opinion, what was lacking on the shipwright.io website was a clear purpose for end-users, highlighting the benefits and interests they could gain from the project. Therefore, the landing page is structured as follows:
Hero Section: Features an image of a terminal displaying a
Build
YAML file. The goal is to immediately showcase Shipwright's capabilities. SinceBuild
is a core component, I thought it was an ideal illustration. Alternatively, this image could be replaced with an architectural diagram of Shipwright + K8s + Tekton. Because "shipwright" is related to maritime world, I have designed an artsy interpretation of waves (as shipwright will make waves into the CNCF landscape!!)Why Shipwright.io: Highlights the project's features - such as Vitess.io did.
Step-by-Step Overview: Demonstrates how easy it is to use Shipwright. It introduces the main components—
BuildStrategy
,Build
, andBuildRun
—in a logical sequence, with illustrations to aid comprehension. This section is inspired by ArgoProj.Footer: Utilizes another CNCF logo available from their GitHub repository. Since Shipwright is a sandbox project, I thought it would be fitting to use the corresponding banner.
Inspiration has been drawn from other CNCF project websites, such as:
All images are created by me, except for the logos from CNCF projects. The repository structure is simplified by Lotus-Docs, offering additional functionalities such as FlexSearch, DocSearch, MermaidJS, and Google Analytics. However, these functionalities are not fully implemented or configured, as they are not the focus of this issue.
What has not been done
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes