Skip to content

Conversation

rxinui
Copy link
Contributor

@rxinui rxinui commented May 14, 2025

Changes

Uses the correct favicon and correct the link preview description.

Fixes #165

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2025
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rxinui
Copy link
Contributor Author

rxinui commented May 14, 2025

@adambkaplan

@adambkaplan
Copy link
Member

This adds a lot of code that is maintained elsewhere (base hugo and the lotusdoc theme). I think this approach is simpler: #167

@SaschaSchwarze0
Copy link
Member

As discussed in the community meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Previews in Slack Show Generic Template Content
3 participants