fix: Correct Favicons and Description #167
Conversation
- Add top-level site description, used to generate previews via meta tags. - Place favicons in the locations that the lotusdocs theme expects. Signed-off-by: Adam Kaplan <[email protected]>
pull-request-size
bot
added
the
size/S
|
@rxinui: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@adambkaplan just a comment. You still need to edit the partial layout like I did here https://github.com/shipwright-io/website/pull/166/files#diff-96dd75a968976edd5e03170268ed9085733f75c3fb24f992ae613c89e6de42dcR1-R62 This is what defines the description in the link preview |
|
Lotusdoc has a feature gap where we can't set the description using Hugo parameters. Filed colinwilson/lotusdocs#239 as a feature request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Changes
Fixes #165
/kind bug
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes