Use make cli-local in CI test suite to remove redundant docker
#6531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
make-cli-no-docker
branch
from
38bc984 to
a3e45a5
Compare
jimmygchen
force-pushed
the
make-cli-no-docker
branch
from
a3e45a5 to
9d28519
Compare
macladson
approved these changes
Oct 22, 2024
macladson
reviewed
Oct 22, 2024
macladson
changed the title
make climake cli-local in CI test suite to remove redundant docker
Co-authored-by: Mac L <[email protected]>
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ad229a6 |
This was referenced Oct 22, 2024
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
…p#6531) * Remove docker command from `make cli`. * Run `cli-local` on CI. * Update Makefile Co-authored-by: Mac L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I noticed that our
clijob sometimes take quite a while and take a fewdocker pullretries before it completes. This is because it attempts to pull the 2.2 GBgithub-runnerimage to run the the cli script in a docker container.I think we can safely replace the
clicommand to run withcargodirectly instead of running it with agithub-runnerimage, as the job runs in a container running thegithub-runnerimage, so this is a bit redundant and slow.