RequestType::max_responses for LightClientUpdatesByRange

[ackintosh]

Issue Addressed

In case of RequestType::LightClientUpdatesByRange, RequestType::max_responses() returns the number that LightClientUpdatesByRangeRequest::max_requested() returns, which is a constant value representing the maximum number of LightClientUpdate instances in a single request. I think it should return the actual number of instances the request requires, instead of the constant value defined in the spec.

[jimmygchen]

Good catch!

This is also consistent with the spec, with the max size enforced in the handling method:

The response MUST NOT contain more than min(MAX_REQUEST_LIGHT_CLIENT_UPDATES, count) results

[jimmygchen]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[jimmygchen]

Failed due to crates.io download issue, will requeue.

[jimmygchen]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 40d3423