Minor refactor to verify SCT and Rekor entry with multiple keys #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to verify old entries using a set of trusted keys. No changes are needed for Fulcio, since the underlying verification library already accepts multiple trusted roots. Ref sigstore#1273 Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
force-pushed
the
multiple-trust
branch
from
1980919 to
290c48c
Compare
dlorenc
approved these changes
Feb 4, 2022
Member
|
Nice! |
Member
|
Looks like another Windows flake. Reran it. #1389 |
Contributor
Author
|
Thanks Dan, what a strange flake. |
haydentherapper
added a commit
to haydentherapper/cosign
that referenced
this pull request
Feb 7, 2022
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <[email protected]>
dlorenc
pushed a commit
that referenced
this pull request
Feb 8, 2022
Introduced in #1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <[email protected]>
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
…tore#1396) This will be used to verify old entries using a set of trusted keys. No changes are needed for Fulcio, since the underlying verification library already accepts multiple trusted roots. Ref sigstore#1273 Signed-off-by: Hayden Blauzvern <[email protected]>
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…tore#1396) This will be used to verify old entries using a set of trusted keys. No changes are needed for Fulcio, since the underlying verification library already accepts multiple trusted roots. Ref sigstore#1273 Signed-off-by: Hayden Blauzvern <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Introduced in sigstore#1396, this incorrectly checked err instead of verifySctErr. This resulted in no error being printed when SCT validation failed. Verified this is working correctly now with local testing. Signed-off-by: Hayden Blauzvern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to verify old entries using a set of trusted
keys. No changes are needed for Fulcio, since the underlying
verification library already accepts multiple trusted roots.
Ref #1273
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes
Release Note