Skip to content

Patch/DF-21368 lido por remove ripcord #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented May 30, 2025

Closes #DF-21368

Description

Follow up to #3887, entirely removing ripcord from lido-por EA since it isn't being used for it's regular purpose here.

Steps to Test

  1. yarn test lido-por
  2. sanity test with payload
{
    "data": {
        "endpoint": "reserve",
        "lidoContract": "0xae7ab96520de3a18e5e111b5eaab095312d7fe84"
    }
}

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested a review from a team May 30, 2025 16:21
Copy link

changeset-bot bot commented May 30, 2025

🦋 Changeset detected

Latest commit: 7a7bf43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/lido-por-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmcallister-cll mmcallister-cll merged commit 5c89c0f into main May 30, 2025
16 checks passed
@mmcallister-cll mmcallister-cll deleted the patch/DF-21368-lido-por-remove-ripcord branch May 30, 2025 17:58
@github-actions github-actions bot mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants