Skip to content

Patch/DF-21368 lido por remove ripcord #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Patch/DF-21368 lido por remove ripcord #3892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8139b23
DF-21368 remove ripcord in lido-por
mmcallister-cll May 30, 2025
7a7bf43
add changeset
mmcallister-cll May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brown-pets-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@chainlink/lido-por-adapter': patch
---

remove ripcord
5 changes: 0 additions & 5 deletions packages/sources/lido-por/src/transport/reserve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ export class BalanceTransport extends SubscriptionTransport<BaseEndpointTypes> {
if (beaconBalance.isNegative()) {
return {
errorMessage: `ethereum-cl-indexer balance endpoint returns negative value ${beaconBalance}`,
ripcord: true,
ripcordDetails: JSON.stringify(
`ethereum-cl-indexer balance endpoint returns negative value`,
),
statusCode: 502,
timestamps: {
providerDataRequestedUnixMs,
Expand All @@ -100,7 +96,6 @@ export class BalanceTransport extends SubscriptionTransport<BaseEndpointTypes> {
return {
data: {
result: balance,
ripcord: false,
},
result: balance,
timestamps: {
Expand Down
5 changes: 1 addition & 4 deletions packages/sources/lido-por/test/integration/__snapshots__/adapter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`execute reserve endpoint should return ripcord 1`] = `
exports[`execute reserve endpoint should return error 1`] = `
{
"errorMessage": "ethereum-cl-indexer balance endpoint returns negative value -1",
"ripcord": true,
"ripcordDetails": ""ethereum-cl-indexer balance endpoint returns negative value"",
"statusCode": 502,
"timestamps": {
"providerDataReceivedUnixMs": 978347471111,
Expand All @@ -17,7 +15,6 @@ exports[`execute reserve endpoint should return success 1`] = `
{
"data": {
"result": "800",
"ripcord": false,
},
"result": "800",
"statusCode": 200,
Expand Down
4 changes: 2 additions & 2 deletions packages/sources/lido-por/test/integration/adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
} from '@chainlink/external-adapter-framework/util/testing-utils'
import { ethers } from 'ethers'
import * as nock from 'nock'
import { mockResponseSuccess, mockResponseFailure } from './fixtures'
import { mockResponseFailure, mockResponseSuccess } from './fixtures'

jest.mock('ethers', () => {
const actualModule = jest.requireActual('ethers')
Expand Down Expand Up @@ -77,7 +77,7 @@ describe('execute', () => {
expect(response.json()).toMatchSnapshot()
})

it('should return ripcord', async () => {
it('should return error', async () => {
const data = {
lidoContract: 'invalid',
}
Expand Down
Loading