Skip to content

Conversation

@thomas-k-cameron
Copy link
Contributor

Motivation and Context

part of RFC30

Description

adds serde under aws_sdk_unstable feature gate

Testing

no testing

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomas-k-cameron thomas-k-cameron marked this pull request as ready for review January 7, 2023 08:50
@thomas-k-cameron thomas-k-cameron requested review from a team as code owners January 7, 2023 08:50
Copy link
Contributor

@jjant jjant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions

Co-authored-by: Julian Antonielli <[email protected]>
@thomas-k-cameron
Copy link
Contributor Author

@jjant
Thank you for your suggestion!

@thomas-k-cameron thomas-k-cameron changed the base branch from main to unstable-serde-support January 13, 2023 00:28
@Velfi Velfi merged commit d11bbf3 into smithy-lang:unstable-serde-support Jan 19, 2023
thomas-k-cameron added a commit to thomas-k-cameron/smithy-rs that referenced this pull request Apr 20, 2023
* Rfc30/document (smithy-lang#2196)

* impl/refactor documet

* impl serde/desr for document

* fix

* add anchor end

* precommit fix

* Rfc30/cargo.toml update (smithy-lang#2180)

* add serde under aws_sdk_unstable

* changelog.next.toml

* Apply suggestions from code review

Co-authored-by: Julian Antonielli <[email protected]>

Co-authored-by: Julian Antonielli <[email protected]>
Co-authored-by: Zelda Hessler <[email protected]>

* Rfc30/blob (smithy-lang#2181)

* rfc30 blob

* blob import fix
add license header
pre commit

* change unstable keyword to aws_sdk_unstable

* change unstable keyword to aws_sdk_unstable

* add test

* updater changelog

* Update CHANGELOG.next.toml

* Update lib.rs

remove extra Document declaration from bad merge

* remove/unused import

Co-authored-by: Zelda Hessler <[email protected]>
Co-authored-by: Zelda Hessler <[email protected]>

* RFC30/datetime (smithy-lang#2184)

* serde support for datetime with testing

* add ciborium to cargo.toml

* update changelog

* refactor
impl suggestions from

* refacotring
better err message

* Revert "update changelog"

This reverts commit d58abfa.

* add/license header

* add: license header

* remove unnecessary returns

Co-authored-by: Zelda Hessler <[email protected]>

* fix: changelog entries

* fix: some serde stuff broken by Zelda in the merges

* Fix unused imports

* Implement serde support for `aws_smithy_types::Number` (smithy-lang#2185)

* add line (smithy-lang#2311)

* RFC30/Set fields to fluent builder (smithy-lang#2310)

* fn set_fields

* add fn set_fields to fluent builder

* better docs

* fix

* improve document
cfg to Attribute class

* Rfc30/feature gate for generated crates (smithy-lang#2183)

* add CfgUnstable for feature-gate

* add features

* add feature-gate

* strings for feature gate

* Revert "strings for feature gate"

This reverts commit 1f33a5c.

* Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/RuntimeType.kt

Co-authored-by: Zelda Hessler <[email protected]>

* fix dependency thing on cargo

* add OutputShape to builder

* EnumGenerator

* StructureGenerator

* UnionGenerator

* todo

* fixed?

* SerdeDecorator

* codegen stuff

* update

* fix

* Apply suggestions from code review

Co-authored-by: Zelda Hessler <[email protected]>

* - refactoring
- pre-commit
- https://github.com/awslabs/smithy-rs/pull/2183/files#r1080594621

* adds serde-serialize/deserialize

* this one causes null pointer exception

* interim solution

* new push

* fix

* add Sensitive Warning

* add test for CargoTomlGeneratorTest
pre-commit fix

* Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGenerator.kt

Co-authored-by: Zelda Hessler <[email protected]>

---------

Co-authored-by: Zelda Hessler <[email protected]>

* Upgrade the smithy-rs runtime crates version to 0.55.0

* Update changelog

* merge

* Revert "merge"

This reverts commit 6f00505.

* squash commit

* update: gradle.properties

---------

Co-authored-by: Julian Antonielli <[email protected]>
Co-authored-by: Zelda Hessler <[email protected]>
Co-authored-by: Zelda Hessler <[email protected]>
Co-authored-by: John DiSanti <[email protected]>
Co-authored-by: AWS SDK Rust Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants