Rfc30/blob #2181
Merged
Rfc30/blob #2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add license header pre commit
Velfi
approved these changes
Jan 9, 2023
Contributor
|
@thomas-k-cameron Once we get the other |
Contributor
Author
|
Do you think you want to create a dedicated branch for temporary merging RFC30/*? I'm pretty sure there will be some merge conflict when you do it. |
Contributor
|
Contributor
Author
|
I prefer having a dedicated branch on this repository. In addition to the merge conflict, it helps me keep track of my progress, write tests... etc I could make a branch on my repo but I think it's less error prone to have it on this repository. Would you mind creating a branch for me? |
Contributor
|
I created the |
Contributor
Author
Velfi
reviewed
Jan 18, 2023
| */ | ||
|
|
||
| #[cfg(all(test, aws_sdk_unstable, feature = "serialize", feature = "deserialize"))] | ||
| mod test; |
Contributor
There was a problem hiding this comment.
Would you mind moving the tests into a module in this same file?
remove extra Document declaration from bad merge
thomas-k-cameron
added a commit
to thomas-k-cameron/smithy-rs
that referenced
this pull request
Apr 20, 2023
* Rfc30/document (smithy-lang#2196) * impl/refactor documet * impl serde/desr for document * fix * add anchor end * precommit fix * Rfc30/cargo.toml update (smithy-lang#2180) * add serde under aws_sdk_unstable * changelog.next.toml * Apply suggestions from code review Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> * Rfc30/blob (smithy-lang#2181) * rfc30 blob * blob import fix add license header pre commit * change unstable keyword to aws_sdk_unstable * change unstable keyword to aws_sdk_unstable * add test * updater changelog * Update CHANGELOG.next.toml * Update lib.rs remove extra Document declaration from bad merge * remove/unused import Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> * RFC30/datetime (smithy-lang#2184) * serde support for datetime with testing * add ciborium to cargo.toml * update changelog * refactor impl suggestions from * refacotring better err message * Revert "update changelog" This reverts commit d58abfa. * add/license header * add: license header * remove unnecessary returns Co-authored-by: Zelda Hessler <[email protected]> * fix: changelog entries * fix: some serde stuff broken by Zelda in the merges * Fix unused imports * Implement serde support for `aws_smithy_types::Number` (smithy-lang#2185) * add line (smithy-lang#2311) * RFC30/Set fields to fluent builder (smithy-lang#2310) * fn set_fields * add fn set_fields to fluent builder * better docs * fix * improve document cfg to Attribute class * Rfc30/feature gate for generated crates (smithy-lang#2183) * add CfgUnstable for feature-gate * add features * add feature-gate * strings for feature gate * Revert "strings for feature gate" This reverts commit 1f33a5c. * Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/RuntimeType.kt Co-authored-by: Zelda Hessler <[email protected]> * fix dependency thing on cargo * add OutputShape to builder * EnumGenerator * StructureGenerator * UnionGenerator * todo * fixed? * SerdeDecorator * codegen stuff * update * fix * Apply suggestions from code review Co-authored-by: Zelda Hessler <[email protected]> * - refactoring - pre-commit - https://github.com/awslabs/smithy-rs/pull/2183/files#r1080594621 * adds serde-serialize/deserialize * this one causes null pointer exception * interim solution * new push * fix * add Sensitive Warning * add test for CargoTomlGeneratorTest pre-commit fix * Update codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/BuilderGenerator.kt Co-authored-by: Zelda Hessler <[email protected]> --------- Co-authored-by: Zelda Hessler <[email protected]> * Upgrade the smithy-rs runtime crates version to 0.55.0 * Update changelog * merge * Revert "merge" This reverts commit 6f00505. * squash commit * update: gradle.properties --------- Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
part of RFC30
Description
Implements serde to
Blobdatatype as described in RFC30.also refactors it to another file
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.