SSF + Payment Element reboot by elia · Pull Request #146 · solidusio/solidus_stripe

elia · 2022-12-19T15:04:01Z

Summary

Fixes Re-create the extension with solidus extension solidus_stripe #141
Sets up a baseline for further development and implementing Payment Element for SSF

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

I have written a thorough PR description.
I have kept my commits small and atomic.
I have used clear, explanatory commit messages.

The following are not always needed (~~cross them out~~ if they are not):

I have added automated tests to cover my changes.
I have attached screenshots to demo visual changes.
I have opened a PR to update the guides.
I have updated the README to account for my changes.

gsmendoza

@elia Looking good! I just have a few questions :)

gsmendoza · 2022-12-22T07:52:14Z

@@ -1,257 +1,30 @@
+🚧 Your looking at the source for `solidus_stripe` v5, which will only support the **starter frontend** and not the classic frontend 🚧


Suggested change

🚧 Your looking at the source for `solidus_stripe` v5, which will only support the **starter frontend** and not the classic frontend 🚧

🚧 You're looking at the source for `solidus_stripe` v5, which will only support the **starter frontend** and not the classic frontend 🚧

gsmendoza · 2022-12-22T08:08:26Z

+
+# rubocop:disable Lint/UnusedMethodArgument, Style/MethodCallWithoutArgsParentheses, Lint/UselessAssignment
+module SolidusStripe
+  class Gateway


Regarding 189dd87, can you provide more details on how Gateway, PaymentMethod, and PaymentSource were built? They seem to follow the API of SolidusPaypalCommercePlatform but their code are not exactly the same.

It's just meant to be a placeholder for the implementation. Given the Gateway API is mandated by Solidus I felt it was ok to stub it out letting the implementation to be added in following PRs.

gsmendoza · 2022-12-22T08:10:30Z

-# how Dependabot parses projects: https://github.com/dependabot/dependabot-core/issues/1658.
-send(:eval_gemfile, 'Gemfile-local') if File.exist? 'Gemfile-local'
+gem 'stringio'
+gem 'timeout'


Regarding 8f043da, the commit message mentions "libvips was missing from the CI", but the commit doesn't seem to do anything about libvips. Maybe the commit message is not up-to-date?

kennyadsl

Left a suggestions, non blocking.

kennyadsl · 2022-12-30T13:47:44Z

@@ -1,257 +1,30 @@
+🚧 You're looking at the source for `solidus_stripe` v5, which will only support the **starter frontend** and not the classic frontend 🚧
+🚧 You can find the source for [v4 on the corresponding branch](https://github.com/solidusio/solidus_stripe/tree/v4) 🚧


I'd also add some accurate instructions about what to do to stick to the old version, suggesting to use the Rubygems version, or if someone wants to stick to github, they will need to change the branch.

Added and updated the layout:

I also added a post install message that should better cover the case of people already using it from source.

Lovely, thanks!

- Run `solidus extension stripe` from scratch - Keep the changelog - Added a notice at the top of the readme - Use the sqlite executor from the official ORB

`timeout` and `stringio` are needed on newer rubies in combo with older Rails.

Solidus will always provide a source if the payment method supports payment profiles.

elia self-assigned this Dec 19, 2022

elia force-pushed the elia/ssf-payment-element-reboot branch 4 times, most recently from a157e11 to 8f043da Compare December 20, 2022 10:52

elia marked this pull request as ready for review December 20, 2022 13:07

This was referenced Dec 20, 2022

SSF + Payment Element reboot (part 2) #147

Closed

Integrate Payment Element #142

Closed

Re-create the extension with solidus extension solidus_stripe #141

Closed

gsmendoza reviewed Dec 22, 2022

View reviewed changes

elia force-pushed the elia/ssf-payment-element-reboot branch from 8f043da to 70dbf47 Compare December 23, 2022 15:39

elia requested a review from gsmendoza December 23, 2022 15:41

elia force-pushed the elia/ssf-payment-element-reboot branch 4 times, most recently from 458d51b to 60ffb93 Compare December 28, 2022 17:23

elia requested a review from kennyadsl December 28, 2022 17:24

kennyadsl approved these changes Dec 30, 2022

View reviewed changes

elia force-pushed the elia/ssf-payment-element-reboot branch 3 times, most recently from 90d05b0 to ad7b428 Compare December 30, 2022 15:44

elia added 5 commits December 30, 2022 16:49

Reboot the extension

fbe1e3c

- Run `solidus extension stripe` from scratch - Keep the changelog - Added a notice at the top of the readme - Use the sqlite executor from the official ORB

Setup the project for running SSF specs

2d2540c

Add basic classes for the payment method, source and gateway

431f599

Install missing dependencies

c8e4747

`timeout` and `stringio` are needed on newer rubies in combo with older Rails.

Only support one version of credit/void for the gateway

d7c1482

Solidus will always provide a source if the payment method supports payment profiles.

elia force-pushed the elia/ssf-payment-element-reboot branch from ad7b428 to d7c1482 Compare December 30, 2022 15:49

elia merged commit 96a2c2e into master Jan 9, 2023

elia deleted the elia/ssf-payment-element-reboot branch January 9, 2023 12:27

elia added this to the v5 milestone Feb 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

SSF + Payment Element reboot#146

SSF + Payment Element reboot#146
elia merged 5 commits into
masterfrom
elia/ssf-payment-element-reboot

elia commented Dec 19, 2022 •

edited

Loading

Uh oh!

gsmendoza left a comment

Uh oh!

gsmendoza Dec 22, 2022

Uh oh!

gsmendoza Dec 22, 2022

Uh oh!

elia Dec 23, 2022

Uh oh!

gsmendoza Dec 22, 2022

Uh oh!

kennyadsl left a comment

Uh oh!

kennyadsl Dec 30, 2022

Uh oh!

elia Dec 30, 2022

Uh oh!

kennyadsl Dec 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,257 +1,30 @@
		🚧 Your looking at the source for `solidus_stripe` v5, which will only support the starter frontend and not the classic frontend 🚧

	🚧 Your looking at the source for `solidus_stripe` v5, which will only support the starter frontend and not the classic frontend 🚧
	🚧 You're looking at the source for `solidus_stripe` v5, which will only support the starter frontend and not the classic frontend 🚧

		@@ -1,257 +1,30 @@
		🚧 You're looking at the source for `solidus_stripe` v5, which will only support the starter frontend and not the classic frontend 🚧
		🚧 You can find the source for [v4 on the corresponding branch](https://github.com/solidusio/solidus_stripe/tree/v4) 🚧

Uh oh!

Uh oh!

Conversation

elia commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

gsmendoza left a comment

Choose a reason for hiding this comment

Uh oh!

gsmendoza Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

gsmendoza Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

elia Dec 23, 2022

Choose a reason for hiding this comment

Uh oh!

gsmendoza Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

kennyadsl left a comment

Choose a reason for hiding this comment

Uh oh!

kennyadsl Dec 30, 2022

Choose a reason for hiding this comment

Uh oh!

elia Dec 30, 2022

Choose a reason for hiding this comment

Uh oh!

kennyadsl Dec 30, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elia commented Dec 19, 2022 •

edited

Loading