Skip to content

SSF + Payment Element reboot (part 2)#147

Closed
elia wants to merge 6 commits into
masterfrom
elia/ssf-payment-element-reboot-part-2
Closed

SSF + Payment Element reboot (part 2)#147
elia wants to merge 6 commits into
masterfrom
elia/ssf-payment-element-reboot-part-2

Conversation

@elia

@elia elia commented Dec 20, 2022

Copy link
Copy Markdown
Member

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

elia added 6 commits December 19, 2022 16:14
- Run `solidus extension stripe` from scratch
- Keep the changelog
- Added a notice at the top of the readme
- Use the sqlite executor from the official ORB
- `libvips` was missing from the CI
- `timeout` and `stringio` are needed on newer rubies in combo with older Rails
@elia elia self-assigned this Dec 20, 2022
@elia elia mentioned this pull request Dec 20, 2022
11 tasks
@elia

elia commented Dec 30, 2022

Copy link
Copy Markdown
Member Author

This ended up being just a spike, the work has moved to other PRs

@elia elia closed this Dec 30, 2022
@elia elia deleted the elia/ssf-payment-element-reboot-part-2 branch December 30, 2022 15:30
@elia elia added this to the v5 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate Payment Element

1 participant