Allow Solidus v4#308
Conversation
It's not available on new solidus versions.
Widen the number of ruby versions we test against.
elia
force-pushed
the
elia/4-by-4
branch
3 times, most recently
from
998de7e to
e7a22db
Compare
Make it compatible with all the supported Solidus versions.
| name: solidusio_extensions/mysql | ||
| ruby_version: "3.1" | ||
| environment: | ||
| FRONTEND: "/home/circleci/project/spec/solidus_frontend_app_template.rb" |
There was a problem hiding this comment.
Can you please better help me understand why this is needed?
There was a problem hiding this comment.
Yes, that's because up to Solidus v3.4 solidus_frontend was available as an option, and by just adding the gem to the gemfile we were able to trick the solidus installer into using it, having removed it in v4 we need a custom app template to install it. Rather than having different behaviors for v3 and v4 we just use the same recipe (which is fairly simple anyway).
There was a problem hiding this comment.
Got it. Sounds like something we will need to use for all extensions that were testing against the old frontend at some point.
| ruby_version: "3.2" | ||
| environment: | ||
| FRONTEND: "/home/circleci/project/spec/solidus_frontend_app_template.rb" | ||
| AUTHENTICATION: "devise" |
There was a problem hiding this comment.
Did we use to test this extension with solidus_auth_devise?
There was a problem hiding this comment.
Yes, it is necessary for triggering saving a customer on stripe within some specs. I had to force it because solidus main wasn't picking it up anymore (probably related to solidus_frontend support being removed).
3 participants
Summary
Ensure v4 works with Solidus 4 and prep for a new minor release to allow existing installations to upgrade to the latest solidus.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: