-
-
Notifications
You must be signed in to change notification settings - Fork 65
Allow Solidus v4 #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Solidus v4 #308
Changes from all commits
79d0623
7c27878
5f9f0ac
11017da
56ce411
a52503a
3e82cac
5a25769
4807b97
b315095
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,33 +10,47 @@ orbs: | |
| # or goes EOL. | ||
| solidusio_extensions: solidusio/extensions@volatile | ||
|
|
||
| executors: | ||
| sqlite: | ||
| description: Run specs with an SQLite | ||
| docker: | ||
| - image: cimg/ruby:2.7-browsers | ||
| environment: | ||
| RAILS_ENV: test | ||
| DB: sqlite | ||
|
|
||
| jobs: | ||
| run-specs-with-postgres: | ||
| executor: solidusio_extensions/postgres | ||
| executor: | ||
| name: solidusio_extensions/postgres | ||
| ruby_version: "3.2" | ||
| environment: | ||
| FRONTEND: "/home/circleci/project/spec/solidus_frontend_app_template.rb" | ||
| AUTHENTICATION: "devise" | ||
| steps: | ||
| - browser-tools/install-chrome | ||
| - solidusio_extensions/run-tests | ||
| - checkout | ||
| - solidusio_extensions/dependencies | ||
| - solidusio_extensions/run-tests-solidus-main | ||
| - solidusio_extensions/store-test-results | ||
|
|
||
| run-specs-with-mysql: | ||
| executor: solidusio_extensions/mysql | ||
| executor: | ||
| name: solidusio_extensions/mysql | ||
| ruby_version: "3.1" | ||
| environment: | ||
| FRONTEND: "/home/circleci/project/spec/solidus_frontend_app_template.rb" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please better help me understand why this is needed?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's because up to Solidus v3.4 solidus_frontend was available as an option, and by just adding the gem to the gemfile we were able to trick the solidus installer into using it, having removed it in v4 we need a custom app template to install it. Rather than having different behaviors for v3 and v4 we just use the same recipe (which is fairly simple anyway).
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. Sounds like something we will need to use for all extensions that were testing against the old frontend at some point. |
||
| steps: | ||
| - browser-tools/install-chrome | ||
| - solidusio_extensions/run-tests | ||
| - checkout | ||
| - solidusio_extensions/dependencies | ||
| - solidusio_extensions/run-tests-solidus-current | ||
| - solidusio_extensions/store-test-results | ||
| run-specs-with-sqlite: | ||
| executor: sqlite | ||
| executor: | ||
| name: solidusio_extensions/sqlite | ||
| ruby_version: "3.0" | ||
| steps: | ||
| - browser-tools/install-chrome | ||
| - solidusio_extensions/run-tests | ||
| - checkout | ||
| - solidusio_extensions/dependencies | ||
| - solidusio_extensions/run-tests-solidus-older | ||
| - solidusio_extensions/store-test-results | ||
| lint-code: | ||
| executor: solidusio_extensions/sqlite-memory | ||
| executor: | ||
| name: solidusio_extensions/sqlite-memory | ||
| ruby_version: "3.0" | ||
| steps: | ||
| - solidusio_extensions/lint-code | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| create_file "public/robots.txt" | ||
| bundle_command "add solidus_frontend --github solidusio/solidus_frontend --branch #{ENV['SOLIDUS_BRANCH'] || 'main'}" | ||
| generate "solidus_frontend:install --auto-accept" | ||
| empty_directory 'lib/generators/solidus_frontend/install' | ||
|
|
||
| create_file 'lib/generators/solidus_frontend/install/install_generator.rb', <<-CODE | ||
| puts "SolidusFrontend::Generators::InstallGenerator was disabled." | ||
| module SolidusFrontend | ||
| module Generators | ||
| class InstallGenerator < Rails::Generators::Base | ||
| class_option :auto_accept, type: :boolean, default: false | ||
| end | ||
| end | ||
| end | ||
| CODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we use to test this extension with solidus_auth_devise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is necessary for triggering saving a customer on stripe within some specs. I had to force it because solidus main wasn't picking it up anymore (probably related to solidus_frontend support being removed).