fix: Clear scene before assign new mesh #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
approved these changes
May 2, 2022
| RApplication * app = RApplication::instance(); | ||
| new RStaticMesh<2>(mesh, app->main()->viewer()->scene()); | ||
| RScene * scene = app->main()->viewer()->scene(); | ||
| for (RStaticMesh<2> * child : scene->findChildren<RStaticMesh<2> *>()) |
Member
There was a problem hiding this comment.
I read about qDeleteAll() for children removal. I keep the loop because I do not know which way is better.
| { | ||
| delete child; | ||
| } | ||
| new RStaticMesh<2>(mesh, scene); |
Member
There was a problem hiding this comment.
The scene variable is already there for the pointer so I reuse it.
Contributor
Author
There was a problem hiding this comment.
Sure. I agree it is better to reuse it.
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #57 by clear the scene nodes of the viewer each time when the Run button is clicked.