Correct the wrong deletion of the controller of scene #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The camera controller of scene is also a child of it. For some reason, QObject::findChildren<RStaticMesh<ND> *>() does not only return RStaticMesh<ND> *, but also the controller. Consequently the controller gets deleted when "show" is called to replace the RStaticMesh. The fix uses a loop through QNode::childNodes() and RTTI in the loop to correctly delete only RStaticMesh<ND>.
yungyuc
commented
May 3, 2022
| { | ||
| RApplication * app = RApplication::instance(); | ||
| RScene * scene = app->main()->viewer()->scene(); | ||
| for (RStaticMesh<2> * child : scene->findChildren<RStaticMesh<2> *>()) |
Member
Author
There was a problem hiding this comment.
The child includes the camera controller which gets deleted although it shouldn't be.
Member
Author
|
@yanagiragi FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera controller of scene is also a child of it. For some reason,
QObject::findChildren<RStaticMesh<ND> *>()does not only returnRStaticMesh<ND> *, but also the controller. Consequently the controller gets deleted when "show" is called to replace theRStaticMesh.The fix uses a loop through
QNode::childNodes()and RTTI in the loop to correctly delete onlyRStaticMesh<ND>.This is to fix the issue introduced in #63 , and eventually addresses #57 .