Skip to content

Generate story with information from backend #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 4, 2018
Merged

Generate story with information from backend #250

merged 12 commits into from
Aug 4, 2018

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented Jul 31, 2018

Features

  • SET_ROLE and SET_USERNAME is replaced by SET_USER, which updates the state with all fields from GET /user
  • Fix some dead links from the game (createInitializer.js)
  • Fix a bug where landing on a 404 page from academy would mean that you could not navigate back to the academy
    • ...but not really. The bug is still there due to the nature of HistoryHelper. But I removed HistoryHelper from being saved in localStorage so that at least a hard refresh on the page would remedy this
  • Allow users to receive new stories without having to log in and out
    • Previously, GET /user is only called on log in. Now, GET /user is also called at the Game component, if state.session.story is undefined.

Todos

  • Implement logic for new field from backend attemptedAll

Resolves #152.

@ning-y ning-y added the waiting label Jul 31, 2018
@coveralls
Copy link

coveralls commented Jul 31, 2018

Pull Request Test Coverage Report for Build 558

  • 12 of 32 (37.5%) changed or added relevant lines in 8 files are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 25.339%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/actions/session.ts 1 2 50.0%
src/sagas/backend.ts 1 2 50.0%
src/mocks/backend.ts 1 3 33.33%
src/components/academy/game/create-initializer.js 0 4 0.0%
src/components/academy/game/index.tsx 3 15 20.0%
Files with Coverage Reduction New Missed Lines %
src/components/academy/game/game.js 1 0.0%
src/mocks/backend.ts 1 25.4%
src/components/academy/game/create-initializer.js 1 0.0%
src/components/academy/game/index.tsx 2 20.0%
src/components/workspace/MCQChooser.tsx 18 8.51%
Totals Coverage Status
Change from base Build 545: -0.3%
Covered Lines: 848
Relevant Lines: 2832

💛 - Coveralls

@ning-y ning-y added wip and removed waiting labels Aug 3, 2018
@ning-y ning-y requested a review from remo5000 August 3, 2018 11:44
@ning-y ning-y removed the wip label Aug 3, 2018
@ning-y
Copy link
Member Author

ning-y commented Aug 3, 2018

@remo5000 I'm using this PR to bump v0.1.7 to v0.1.8, so we need to merge #266 first if you want to include it in the next staging bump.

@ning-y ning-y merged commit f5d83cc into master Aug 4, 2018
@ning-y ning-y deleted the story branch August 4, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants