Add grading details when adding adjustments #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 568
💛 - Coveralls |
|
Not sure if you're done yet, but the editor isn't showing up for me when I run this with the mock data. |
1 task
|
Fixed, it was a css issue. |
|
Lmk with request reviews when you're done |
ning-y
requested changes
Aug 5, 2018
There was a problem hiding this comment.
- Make the
tableblock element fill the side content in width.- This causes the
div.pt-numeric-inputto be flushed to the right, and as a result its buttons may look better on its right - Also because of this change, the text align of labels on the left might look better with
text-align: leftinstead oftext-align: center
- This causes the
- Grader save button should be at the bottom of the markdown editor since it saves not just adjustment but also comments
- As a result of this change this button may look better if it filled up all horizontal space (I think
Buttontakes a prop that makes this possible)
- As a result of this change this button may look better if it filled up all horizontal space (I think
- Can you make the grader save button change colour in the same way that the assessments save button does?
ning-y
approved these changes
Aug 7, 2018
Aulud
pushed a commit
to Aulud/cadet-frontend
that referenced
this pull request
May 25, 2020
Bumps [quantum](https://github.com/quantum-elixir/quantum-core) from 2.3.2 to 2.3.3. - [Release notes](https://github.com/quantum-elixir/quantum-core/releases) - [Changelog](https://github.com/quantum-elixir/quantum-core/blob/master/CHANGELOG.md) - [Commits](quantum-elixir/quantum-core@v2.3.2...v2.3.3) Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features