Skip to content

Remove deprecated exposure types from schema definitions#636

Merged
WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:remove_outdated_exposure
Jul 10, 2025
Merged

Remove deprecated exposure types from schema definitions#636
WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:remove_outdated_exposure

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Collaborator

Resolves RAD-nnnn

Closes #606

This PR removes the outdated exposure types.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 10, 2025 17:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.73%. Comparing base (d2da141) to head (3ec9ead).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files           8        8           
  Lines         644      644           
=======================================
  Hits          623      623           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit c042276 into spacetelescope:main Jul 10, 2025
18 of 22 checks passed
@WilliamJamieson WilliamJamieson deleted the remove_outdated_exposure branch July 10, 2025 18:21
@braingram braingram mentioned this pull request Jul 10, 2025
13 tasks
@braingram
Copy link
Copy Markdown
Collaborator

Is there a new set of regression test files for this PR?

The scheduled run showed several failures:
https://github.com/spacetelescope/RegressionTests/actions/runs/16208770638
of the type:

failed on setup with "asdf._jsonschema.exceptions.ValidationError: 'WFI_GRISM' is not one of ['WFI_IMAGE', 'WFI_SPECTRAL', 'WFI_IM_DARK', 'WFI_SP_DARK', 'WFI_FLAT', 'WFI_LOLO', 'WFI_WFSC']

If these files aren't available can we revert this PR until they are? That way other roman work can continue to use the regtests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Outdated Exposure Types

3 participants