Skip to content

Remove usage of outdated exposure types#537

Merged
WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:remove_outdated_exposure
Jul 10, 2025
Merged

Remove usage of outdated exposure types#537
WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:remove_outdated_exposure

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Contributor

@WilliamJamieson WilliamJamieson commented Jul 10, 2025

This PR fixes RDM for spacetelescope/rad#636 changes in RDM, by changing the usage of some of the exposure_types to non-outdated ones.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 10, 2025 17:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.84%. Comparing base (087a60d) to head (9661a88).
⚠️ Report is 196 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   97.56%   97.84%   +0.28%     
==========================================
  Files          30       40      +10     
  Lines        2788     4313    +1525     
==========================================
+ Hits         2720     4220    +1500     
- Misses         68       93      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit a7085d6 into spacetelescope:main Jul 10, 2025
20 checks passed
@WilliamJamieson WilliamJamieson deleted the remove_outdated_exposure branch July 10, 2025 18:21
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants