Warn if memory keymanager is used with non-reattestable attestor#7139
Open
sorindumitru wants to merge 1 commit into
Open
Warn if memory keymanager is used with non-reattestable attestor#7139sorindumitru wants to merge 1 commit into
sorindumitru wants to merge 1 commit into
Conversation
Signed-off-by: Sorin Dumitru <sorin@returnze.ro>
sorindumitru
requested review from
MarcosDY,
amartinezfayo,
evan2645 and
rturner3
as code owners
There was a problem hiding this comment.
Pull request overview
Adds an operational warning in the SPIRE Agent startup/manager initialization path to help users avoid a configuration that can strand the agent after restart (non-reattestable node attestation + in-memory key manager).
Changes:
- Emit a warning when
AttestationResult.Reattestableis false and the configured KeyManager plugin ismemory
Comment on lines
+395
to
+397
| if !as.Reattestable && cat.GetKeyManager().Name() == "memory" { | ||
| a.c.Log.Warn("Node attestation is not reattestable and the 'memory' key manager is in use; if the agent process is restarted, it will be unable to obtain a new SVID and will need to be manually evicted to be able to re-attest.") | ||
| } |
Member
Author
There was a problem hiding this comment.
I don't think those fields are relevant here. We just want to communicate to the user that something is wrong about the deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be useful for users.