Skip to content

Warn if memory keymanager is used with non-reattestable attestor #7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sorindumitru wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Warn if memory keymanager is used with non-reattestable attestor #7139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,10 @@ func (a *Agent) attest(ctx context.Context, sto storage.Storage, cat catalog.Cat
}

func (a *Agent) newManager(ctx context.Context, sto storage.Storage, cat catalog.Catalog, metrics telemetry.Metrics, as *node_attestor.AttestationResult, cache *storecache.Cache, na nodeattestor.NodeAttestor) (manager.Manager, error) {
if !as.Reattestable && cat.GetKeyManager().Name() == "memory" {
a.c.Log.Warn("Node attestation is not reattestable and the 'memory' key manager is in use; if the agent process is restarted, it will be unable to obtain a new SVID and will need to be manually evicted to be able to re-attest.")
}
Comment on lines +395 to +397

@sorindumitru sorindumitru Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those fields are relevant here. We just want to communicate to the user that something is wrong about the deployment.


config := &manager.Config{
SVID: as.SVID,
SVIDKey: as.Key,
Expand Down
Loading