Skip to content

Updated construct_api logic to parse host value #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockb1017 merged 3 commits into from
Dec 8, 2021
Merged

Updated construct_api logic to parse host value #198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c864fb0
Updated construct_api
Nov 23, 2021
4becf39
added full_url config
Dec 1, 2021
74beda6
added validation and testcase
Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/fluent/plugin/out_splunk_hec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,9 @@ def format_metric(tag, time, record)
end

def construct_api
URI("#{@protocol}://#{@hec_host}:#{@hec_port}/services/collector")
host = @hec_host.delete_prefix("/").delete_suffix("/").split("/", 2)
host_suffix = host[1].nil? ? "" : "/#{host[1]}"
URI("https://#{host[0]}:#{@hec_port}#{host_suffix}/services/collector")
Copy link
Contributor

@rockb1017 rockb1017 Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can only support one path, right? can it be updated so that it can support any number of it?
like https://mydomain.com/splunk/hec

Copy link
Contributor

@rockb1017 rockb1017 Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a better approach would be adding another parameter. full_url.
use full_url if provided. if not build one using host, port, and protocol .
@chaitanyaphalak any thoughts?

Copy link
Contributor Author

@hvaghani221 hvaghani221 Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can only support one path, right? can it be updated so that it can support any number of it? like https://mydomain.com/splunk/hec

It will support any number of path as I am splitting host in 2 half only.
For mydomain.com/splunk/hec, it will split into mydomain.com and splunk/hec and will be join them with port value

Copy link
Contributor

@chaitanyaphalak chaitanyaphalak Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like rock's idea

Copy link
Contributor

@rockb1017 rockb1017 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshit-splunk i see. so it works.
hmm still, this way of parsing is not intuitive for the user.
instead of full_url we can add url_path parameter.
default would be "" but user can set it to /splunk/hec or anything.

However, having a full_url parameter is something that will benefit usability in the future. we can use it in the helm chart to reduce number of arguments that they need to pass.
this way, we are consistent with olly chart. (ie splunkPlatform.endpoint)

Copy link
Contributor

@rockb1017 rockb1017 Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshit-splunk
So I would like to suggest to edit this PR with full_url approach.

rescue StandardError
raise Fluent::ConfigError, "hec_host (#{@hec_host}) and/or hec_port (#{@hec_port}) are invalid."
end
Expand Down