Skip to content

PluginBuilderFactory instead of PluginFactory for Log4j2 Appender #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Scip88 opened this issue Jan 13, 2020 · 3 comments · Fixed by #1144
Closed

PluginBuilderFactory instead of PluginFactory for Log4j2 Appender #1142

Scip88 opened this issue Jan 13, 2020 · 3 comments · Fixed by #1144
Labels
type: improvement
Milestone
2.2.4

Comments

@Scip88
Copy link
Contributor

Scip88 commented Jan 13, 2020 •
edited
Loading

Affects Version(s): v2.2.2.RELEASE

Use of PluginBuilderFactory instead of PluginFactory for Log4j2 AmqpAppender

I'm tryin to extends AmqpAppender to customize method postProcessMessageBeforeSend.
I'm tryin to avoid copy & paste of static method createAppender (annotated with PluginFactory) but it's not possibile.

Is there another solution or simple code to create a method annotated with PluginFactory ?

I suggest to use Builder and Annotation PluginBuilderFactory

Extend Log4j2 Appenders
Log4j2 Plugin Builder
@Scip88 Scip88 changed the title PluginBuilderF actory instead of PluginFactory for Log4j2 Appender PluginBuilderFactory instead of PluginFactory for Log4j2 Appender Jan 13, 2020
@garyrussell garyrussell added this to the Backlog milestone Jan 13, 2020
@garyrussell
Copy link
Contributor

Sounds reasonable. Contributions are welcome.

@Scip88
Copy link
Contributor Author

Scip88 commented Jan 13, 2020 •
edited
Loading

I hope to work on that enhancement ASAP

Scip88 added a commit to Scip88/spring-amqp that referenced this issue Jan 16, 2020
@Scip88
resolve spring-projects#1142
f1aafce 
Refactor @pluginfactory and use of @PluginBuilderFactory

Simplify subclasses implementation of AmqpAppender (Log4j2)
@Scip88 Scip88 mentioned this issue Jan 16, 2020
Merged
@artembilan
Copy link
Member

Reopened. Closed by mistaken issue link in other commit.

@artembilan artembilan reopened this Jan 16, 2020
garyrussell pushed a commit to spring-projects/spring-integration that referenced this issue Jan 16, 2020
@sergebg @garyrussell
GH-3143: Fix simple pool resizing
3850c7e 
Resolves spring-projects/spring-amqp#1142

Resize down does not work when not enough already allocated to match the reduction.

Improved SimplePool test cases and fixed code style

Fixed code style

GH-3143: Test Polishing

- use preferred assertJ expected exception checking
- add a test for reducing a partially allocated pool
- check active counts
garyrussell pushed a commit that referenced this issue Jan 21, 2020
@Scip88 @garyrussell
Use of PluginBuilderFactory on AmqpAppender (Log4j2) (#1144)
abc96cf 
* resolve #1142

Refactor @pluginfactory and use of @PluginBuilderFactory

Simplify subclasses implementation of AmqpAppender (Log4j2)

* Change Reference Documentation

Add Example for Log4j2 subclasses and static factor

* add test and fix logging.adoc

* fix LICENSE and logging.adoc

* fix missing rename file

* ConnectionFactory destroy() to avoid resources leaking
@garyrussell garyrussell modified the milestones: Backlog, 2.2.4 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement
Projects
None yet
Milestone
2.2.4
Development

Successfully merging a pull request may close this issue.

Use of PluginBuilderFactory on AmqpAppender (Log4j2) Scip88/spring-amqp
3 participants
@garyrussell @artembilan @Scip88